Uh oh!
There was an error while loading. Please reload this page.
[SPARK-20365][YARN] Remove LocalSchem when add path to ClassPath. - #18129
Closed
lycplus wants to merge 5 commits into
Closed
[SPARK-20365][YARN] Remove LocalSchem when add path to ClassPath.#18129lycplus wants to merge 5 commits into
lycplus wants to merge 5 commits into
Conversation
| if (LOCAL_SCHEME.equals(uri.getScheme())) { | ||
| cp should contain (uri.getPath()) | ||
| if (LOCAL_SCHEME.equals(uri.getScheme)) { | ||
| cp should contain (uri.getPath) |
Contributor
There was a problem hiding this comment.
Maybe it is not so necessary to change the previous style.
ContributorAuthor
There was a problem hiding this comment.
It is Intellij that advises the above changes. I will revert them.
jerryshao
commented
May 31, 2017
Contributor
CC @vanzin to take a review. |
vanzin
reviewed
May 31, 2017
vanzin
left a comment
Contributor
There was a problem hiding this comment.
Style nit, otherwise looks good pending tests.
| cp should contain (uri.getPath()) | ||
| } else { | ||
| cp should not contain (uri.getPath()) | ||
| cp should not contain uri.getPath() |
Contributor
There was a problem hiding this comment.
Could you avoid these noisy changes and also keep the existing style of using parentheses in the code you're actually adding?
vanzin
commented
May 31, 2017
Contributor
ok to test |
SparkQA
commented
May 31, 2017
Test build #77596 has finished for PR 18129 at commit
|
SparkQA
commented
Jun 1, 2017
Test build #77623 has finished for PR 18129 at commit
|
| cp should not contain (uri.getPath()) | ||
| } | ||
| }) | ||
| cp should not contain "local" |
Contributor
There was a problem hiding this comment.
Can you please add parentheses here ("local").
SparkQA
commented
Jun 1, 2017
Test build #77645 has finished for PR 18129 at commit
|
vanzin
commented
Jun 1, 2017
Contributor
Merging to master / 2.2. |
asfgit pushed a commit
that referenced
this pull request
Jun 1, 2017
In Spark on YARN, when configuring "spark.yarn.jars" with local jars (jars started with "local" scheme), we will get inaccurate classpath for AM and containers. This is because we don't remove "local" scheme when concatenating classpath. It is OK to run because classpath is separated with ":" and java treat "local" as a separate jar. But we could improve it to remove the scheme. Updated `ClientSuite` to check "local" is not in the classpath. cc jerryshao Author: Li Yichao <lyc@zhihu.com> Author: Li Yichao <liyichao.good@gmail.com> Closes#18129 from liyichao/SPARK-20365. (cherry picked from commit 640afa4) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
vanzin
commented
Jun 1, 2017
Contributor
@liyichao please update the bug with your JIRA handle if you want it assigned to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In Spark on YARN, when configuring "spark.yarn.jars" with local jars (jars started with "local" scheme), we will get inaccurate classpath for AM and containers. This is because we don't remove "local" scheme when concatenating classpath. It is OK to run because classpath is separated with ":" and java treat "local" as a separate jar. But we could improve it to remove the scheme.
How was this patch tested?
Updated
ClientSuiteto check "local" is not in the classpath.cc @jerryshao