Uh oh!
There was an error while loading. Please reload this page.
[SPARK-21103][SQL] QueryPlanConstraints should be part of LogicalPlan - #18310
Closed
rxin wants to merge 1 commit into
Closed
[SPARK-21103][SQL] QueryPlanConstraints should be part of LogicalPlan#18310rxin wants to merge 1 commit into
rxin wants to merge 1 commit into
Conversation
ContributorAuthor
SparkQA
commented
Jun 15, 2017
Test build #78078 has finished for PR 18310 at commit
|
rxin
commented
Jun 15, 2017
ContributorAuthor
Closing for now, since @sameeragarwal said it might be useful in physical planning in the future. |
SparkQA
commented
Jun 15, 2017
Test build #78087 has started for PR 18310 at commit |
SparkQA
commented
Jun 15, 2017
Test build #3798 has finished for PR 18310 at commit
|
rxin
commented
Jun 20, 2017
ContributorAuthor
Merging in master. |
sameeragarwal
commented
Jun 20, 2017
Member
LGTM |
robert3005 pushed a commit
to palantir/spark
that referenced
this pull request
Jun 29, 2017
## What changes were proposed in this pull request? QueryPlanConstraints should be part of LogicalPlan, rather than QueryPlan, since the constraint framework is only used for query plan rewriting and not for physical planning. ## How was this patch tested? Should be covered by existing tests, since it is a simple refactoring. Author: Reynold Xin <rxin@databricks.com> Closesapache#18310 from rxin/SPARK-21103.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
QueryPlanConstraints should be part of LogicalPlan, rather than QueryPlan, since the constraint framework is only used for query plan rewriting and not for physical planning.
How was this patch tested?
Should be covered by existing tests, since it is a simple refactoring.