Uh oh!
There was an error while loading. Please reload this page.
[SPARK-21210][DOC][ML] Javadoc 8 fixes for ML shared param traits - #18420
[SPARK-21210][DOC][ML] Javadoc 8 fixes for ML shared param traits#18420MLnick wants to merge 1 commit into
Conversation
MLnick
commented
Jun 26, 2017
Just as a little side note, actually, while fixing some javadoc at that time, I realised that even LGTM. |
SparkQA
commented
Jun 26, 2017
Test build #78637 has finished for PR 18420 at commit
|
MLnick
commented
Jun 27, 2017
@HyukjinKwon true it is private. But there is the possibility that (at least some of) these shared params are made public in the future. So worth doing I guess. |
MLnick
commented
Jun 27, 2017
Jenkins retest this please |
SparkQA
commented
Jun 27, 2017
Test build #78684 has finished for PR 18420 at commit
|
MLnick
commented
Jun 27, 2017
Will wait for pip tests to get sorted out before trying again! |
HyukjinKwon
commented
Jun 27, 2017
Sad ... I guess it fails only on some environments in Jenkins BTW. |
SparkQA
commented
Jun 28, 2017
Test build #3817 has finished for PR 18420 at commit
|
MLnick
commented
Jun 29, 2017
Jenkins retest this please |
SparkQA
commented
Jun 29, 2017
Test build #78885 has finished for PR 18420 at commit
|
srowen
commented
Jun 29, 2017
Merged to master/2.2 |
PR #15999 included fixes for doc strings in the ML shared param traits (occurrences of `>` and `>=`). This PR simply uses the HTML-escaped version of the param doc to embed into the Scaladoc, to ensure that when `SharedParamsCodeGen` is run, the generated javadoc will be compliant for Java 8. ## How was this patch tested? Existing tests Author: Nick Pentreath <nickp@za.ibm.com> Closes#18420 from MLnick/shared-params-javadoc8. (cherry picked from commit 70085e8) Signed-off-by: Sean Owen <sowen@cloudera.com>
PR apache#15999 included fixes for doc strings in the ML shared param traits (occurrences of `>` and `>=`). This PR simply uses the HTML-escaped version of the param doc to embed into the Scaladoc, to ensure that when `SharedParamsCodeGen` is run, the generated javadoc will be compliant for Java 8. ## How was this patch tested? Existing tests Author: Nick Pentreath <nickp@za.ibm.com> Closesapache#18420 from MLnick/shared-params-javadoc8.
PR #15999 included fixes for doc strings in the ML shared param traits (occurrences of
>and>=).This PR simply uses the HTML-escaped version of the param doc to embed into the Scaladoc, to ensure that when
SharedParamsCodeGenis run, the generated javadoc will be compliant for Java 8.How was this patch tested?
Existing tests