Uh oh!
There was an error while loading. Please reload this page.
[SPARK-21241][MLlib]- Add setIntercept to StreamingLinearRegressionWi… - #18457
[SPARK-21241][MLlib]- Add setIntercept to StreamingLinearRegressionWi…#18457SoulGuedria wants to merge 2 commits into
Conversation
…thSGD in Pyspark. StreamingLinearRegressionWithSGD class in PySpark is missing the setIntercept Method which offers the possibility to turn on/off the intercept value. API parity is not respected between Python and Scala. We add the setIntercept Method to StreamingLinearRegressionWithSGD class which calls setIntercept Method in LinearRegressionModel class in order to turn on/off the intercept. A big thanks to Matthieu CANEILL for his precious help in solving the issue. This patch was tested by running all tests with ./dev/run-tests and by manual tests.
holdenk
commented
Oct 10, 2017
So we're only really doing bug fixes on the old MLlib stuff, but I guess we haven't finalized the new ML streaming stuff so I'm not sure what we want to do here. cc @MLnick . |
holdenk
commented
Oct 10, 2017
In the meantime Jenkins OK to test. |
holdenk
commented
Nov 18, 2017
Jenkins, test this plase. |
holdenk
commented
Nov 18, 2017
err Jenkins test this please. |
SparkQA
commented
Nov 18, 2017
Test build #83986 has finished for PR 18457 at commit
|
HyukjinKwon
commented
Jul 16, 2018
ping @SoulGuedria. Seems we should fix the python style. |
SoulGuedria
commented
Jul 16, 2018
Yes i will do it very soon :) Thanks |
holdenk
commented
Jul 27, 2018
So MLlib is even further into maintenance mode, do we want to take improvement parity patches like these? cc @MLnick@jkbradley@HyukjinKwon ? I'm leaning towards no and focusing on ML but it's a mild lean. |
SoulGuedria
commented
Oct 3, 2018
cc @HyukjinKwon can you take a look at this please. Thanks :) |
srowen
commented
Oct 6, 2018
No, we should not merge this. The Model class should not let you set the intercept. This doesn't exist in Scala either. The algorithm implementation does though. |
holdenk
commented
Oct 12, 2018
Sounds like we're not going to change this @SoulGuedria but we'd love your contributions in Spark ML where things are actively being developed. |
holdenk
commented
Oct 19, 2018
Would you be OK closing this PR @SoulGuedria |
AmplabJenkins
commented
Oct 22, 2018
Can one of the admins verify this patch? |
Closesapache#22567Closesapache#18457Closesapache#21517Closesapache#21858Closesapache#22383Closesapache#19219Closesapache#22401Closesapache#22811Closesapache#20405Closesapache#21933Closesapache#22819 from srowen/ClosePRs. Authored-by: Sean Owen <sean.owen@databricks.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
…thSGD in Pyspark.
What changes were proposed in this pull request?
StreamingLinearRegressionWithSGD class in PySpark is missing the setIntercept Method which offers the possibility to turn on/off the intercept value. API parity is not respected between Python and Scala. We added the setIntercept Method to StreamingLinearRegressionWithSGD class which calls setIntercept Method in LinearRegressionModel class in order to turn on/off the intercept. A big thanks to Matthieu CANEILL for his precious help in solving this issue.
How was this patch tested?
This patch was tested by running all tests with ./dev/run-tests.