Skip to content

Turn UpdateBlockInfo into case class. - #1872

Closed
rxin wants to merge 1 commit into
apache:masterfrom
rxin:UpdateBlockInfo
Closed

Turn UpdateBlockInfo into case class.#1872
rxin wants to merge 1 commit into
apache:masterfrom
rxin:UpdateBlockInfo

Conversation

@rxin

@rxinrxin commented Aug 10, 2014

Copy link
Copy Markdown
Contributor

This helps us log UpdateBlockInfo properly once #1870 is merged.

@SparkQA

SparkQA commented Aug 10, 2014

Copy link
Copy Markdown

QA tests have started for PR 1872. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18269/consoleFull

@mengxr

mengxr commented Aug 10, 2014

Copy link
Copy Markdown
Contributor

LGTM and wait for Jenkins ...

@SparkQA

SparkQA commented Aug 10, 2014

Copy link
Copy Markdown

QA results for PR 1872:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds the following public classes (experimental):
case class UpdateBlockInfo(

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/18269/consoleFull

@rxin

rxin commented Aug 10, 2014

Copy link
Copy Markdown
ContributorAuthor

I'm going to merge this one into master & branch-1.1 since the test failure is independent of this.

asfgit pushed a commit that referenced this pull request Aug 10, 2014
@rxin
Turn UpdateBlockInfo into case class.
076ddda
This helps us log UpdateBlockInfo properly once #1870 is merged.
Author: Reynold Xin <rxin@apache.org>
Closes#1872 from rxin/UpdateBlockInfo and squashes the following commits:
0cee1c2 [Reynold Xin] Turn UpdateBlockInfo into case class.
(cherry picked from commit 482c5af)
Signed-off-by: Reynold Xin <rxin@apache.org>
@mridulm

mridulm commented Aug 10, 2014

Copy link
Copy Markdown
Contributor

If case class then does it still need to be Externalizable ?

@rxin
rxin deleted the UpdateBlockInfo branch August 10, 2014 19:11
@rxin

rxin commented Aug 10, 2014

Copy link
Copy Markdown
ContributorAuthor

It is using some custom serialization to reduce serialization overhead.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@rxin@conviva-zz
Turn UpdateBlockInfo into case class.
00d05ee
This helps us log UpdateBlockInfo properly once apache#1870 is merged.
Author: Reynold Xin <rxin@apache.org>
Closesapache#1872 from rxin/UpdateBlockInfo and squashes the following commits:
0cee1c2 [Reynold Xin] Turn UpdateBlockInfo into case class.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rxin@SparkQA@mengxr@mridulm