Uh oh!
There was an error while loading. Please reload this page.
[SPARK-21721][SQL][Backport-2.1] Clear FileSystem deleteOnExit cache when paths are successfully removed - #18947
Closed
viirya wants to merge 1 commit into
Closed
[SPARK-21721][SQL][Backport-2.1] Clear FileSystem deleteOnExit cache when paths are successfully removed#18947viirya wants to merge 1 commit into
viirya wants to merge 1 commit into
Conversation
viirya
commented
Aug 15, 2017
MemberAuthor
cc @yzheng616@gatorsmile Backport #18934 to branch 2.1. |
SparkQA
commented
Aug 15, 2017
Test build #80665 has finished for PR 18947 at commit
|
gatorsmile
approved these changes
Aug 15, 2017
gatorsmile
commented
Aug 15, 2017
Member
LGTM Merging to 2.1 |
asfgit pushed a commit
that referenced
this pull request
Aug 15, 2017
…when paths are successfully removed ## What changes were proposed in this pull request? Backport SPARK-21721 to branch 2.1: We put staging path to delete into the deleteOnExit cache of FileSystem in case of the path can't be successfully removed. But when we successfully remove the path, we don't remove it from the cache. We should do it to avoid continuing grow the cache size. ## How was this patch tested? Added test. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes#18947 from viirya/SPARK-21721-backport-2.1.
gatorsmile
commented
Aug 15, 2017
Member
@viirya Could you close it? Thanks! |
viirya
commented
Aug 15, 2017
MemberAuthor
Thanks @gatorsmile@dongjoon-hyun |
jzhuge pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
…when paths are successfully removed Backport SPARK-21721 to branch 2.1: We put staging path to delete into the deleteOnExit cache of FileSystem in case of the path can't be successfully removed. But when we successfully remove the path, we don't remove it from the cache. We should do it to avoid continuing grow the cache size. Added test. Author: Liang-Chi Hsieh <viirya@gmail.com> Closesapache#18947 from viirya/SPARK-21721-backport-2.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport SPARK-21721 to branch 2.1:
We put staging path to delete into the deleteOnExit cache of FileSystem in case of the path can't be successfully removed. But when we successfully remove the path, we don't remove it from the cache. We should do it to avoid continuing grow the cache size.
How was this patch tested?
Added test.