Uh oh!
There was an error while loading. Please reload this page.
[SQL] [MINOR] [TEST] Set spark.unsafe.exceptionOnMemoryLeak to true - #18967
Closed
gatorsmile wants to merge 1 commit into
Closed
[SQL] [MINOR] [TEST] Set spark.unsafe.exceptionOnMemoryLeak to true#18967gatorsmile wants to merge 1 commit into
gatorsmile wants to merge 1 commit into
Conversation
gatorsmile
commented
Aug 16, 2017
MemberAuthor
SparkQA
commented
Aug 16, 2017
Test build #80751 has finished for PR 18967 at commit
|
gatorsmile
commented
Aug 16, 2017
MemberAuthor
retest this please |
sameeragarwal
approved these changes
Aug 17, 2017
cloud-fan
commented
Aug 17, 2017
Contributor
LGTM |
1 similar comment
kiszk
commented
Aug 17, 2017
Member
LGTM |
cloud-fan
commented
Aug 17, 2017
Contributor
shall we also update |
SparkQA
commented
Aug 17, 2017
Test build #80753 has finished for PR 18967 at commit
|
dongjoon-hyun
commented
Aug 17, 2017
Member
+1 for updating pom and SparkBuild.scala. |
gatorsmile
commented
Aug 17, 2017
MemberAuthor
Since the changes made in this PR only affect the tests in sql/core and sql/hive package, I will not change pom and SparkBuild.scala, which also cover the testing in the other packages. |
gatorsmile
commented
Aug 17, 2017
MemberAuthor
Thanks! Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When running IntelliJ, we are unable to capture the exception of memory leak detection.
Explicitly setting
spark.unsafe.exceptionOnMemoryLeakin SparkConf when building the SparkSession, instead of reading it from system properties.How was this patch tested?
N/A