[SPARK-21805][SPARKR] Disable R vignettes code on Windows by felixcheung · Pull Request #19016 · apache/spark

felixcheung · 2017-08-22T06:44:16Z

What changes were proposed in this pull request?

Code in vignettes requires winutils on windows to run, when publishing to CRAN or building from source, winutils might not be available, so it's better to disable code run (so resulting vigenttes will not have output from code, but text is still there and code is still there)

fix * checking re-building of vignette outputs ... WARNING
and

%LOCALAPPDATA% not found. Please define the environment variable or restart and enter an installation path in localDir.

How was this patch tested?

jenkins, appveyor, r-hub

before: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-49cecef3bb09db1db130db31604e0293/SparkR.Rcheck/00check.log
after: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-86a066c7576f46794930ad114e5cff7c/SparkR.Rcheck/00check.log

SparkQA · 2017-08-22T07:04:48Z

Test build #80965 has finished for PR 19016 at commit 7c75073.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2017-08-22T07:14:06Z

retest this please

felixcheung · 2017-08-22T07:15:47Z

what's with jenkins? looks like JIRA is not updated either...

HyukjinKwon · 2017-08-22T07:18:43Z

Yes ... for JIRA linking problem, there are some information here - http://apache-spark-developers-list.1001551.n3.nabble.com/Some-PRs-not-automatically-linked-to-JIRAs-td22067.html just FYI. I think -9 has increased recently..

SparkQA · 2017-08-22T08:07:19Z

Test build #80972 has finished for PR 19016 at commit 7c75073.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

shivaram · 2017-08-23T15:02:40Z

Thanks @felixcheung ! Are the warnings about the missing PDF unavoidable ? I see something like

 checking package vignettes in 'inst/doc' ... WARNING
Package vignette without corresponding PDF/HTML:
'sparkr-vignettes.Rmd'

felixcheung · 2017-08-23T15:23:00Z

I think that is caused by the way I build the source package - I use the option --no-build-vignettes so the source package I test with doesn't have the PDF in it Similarly for the failed test - I change the version to 2.2.0 to get it to run without setting the download URL and there is a change on the wrapper class parameter list.

shivaram · 2017-08-23T15:59:58Z

Ah I see. Yeah the failed tests makes sense. We can also try to submit a custom tar.gz to r-hub to test it with the PDF and a different version number ?

felixcheung · 2017-08-23T17:20:15Z

It likely best to back port this to branch-2.2 so the test can pass with matching API in a released jar. Then we can see everything passing (except having to hand edit the version number)

shivaram · 2017-08-23T17:23:13Z

 -->

+```{r setup, include=FALSE}
+library(knitr)


Just to clarify, the opt_hooks is provided by knitr ?

shivaram · 2017-08-23T17:23:32Z

Sure - change LGTM. Lets see if @HyukjinKwon has any more comments ? If not we can merge to master, branch-2.2 and then do some more tests.

SparkQA · 2017-08-23T18:14:13Z

Test build #81040 has finished for PR 19016 at commit 23f9d5e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2017-08-23T23:39:51Z

Sure, I have no more comments and it looks good to me too.

## What changes were proposed in this pull request? Code in vignettes requires winutils on windows to run, when publishing to CRAN or building from source, winutils might not be available, so it's better to disable code run (so resulting vigenttes will not have output from code, but text is still there and code is still there) fix * checking re-building of vignette outputs ... WARNING and > %LOCALAPPDATA% not found. Please define the environment variable or restart and enter an installation path in localDir. ## How was this patch tested? jenkins, appveyor, r-hub before: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-49cecef3bb09db1db130db31604e0293/SparkR.Rcheck/00check.log after: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-86a066c7576f46794930ad114e5cff7c/SparkR.Rcheck/00check.log Author: Felix Cheung <felixcheung_m@hotmail.com> Closes#19016 from felixcheung/rvigwind. (cherry picked from commit 43cbfad) Signed-off-by: Felix Cheung <felixcheung@apache.org>

felixcheung · 2017-08-24T04:35:58Z

thanks, merged to master/2.2.
will check for nightly build from tonight.

felixcheung · 2017-08-25T07:30:14Z

I tested with the nightly, it passed
https://builder.r-hub.io/status/SparkR_2.2.0.tar.gz-fba296d2142edeb8bcdb082e311d8462

shivaram · 2017-08-25T16:48:27Z

Thats great ! I will also run this by winbuilder later today.

## What changes were proposed in this pull request? Code in vignettes requires winutils on windows to run, when publishing to CRAN or building from source, winutils might not be available, so it's better to disable code run (so resulting vigenttes will not have output from code, but text is still there and code is still there) fix * checking re-building of vignette outputs ... WARNING and > %LOCALAPPDATA% not found. Please define the environment variable or restart and enter an installation path in localDir. ## How was this patch tested? jenkins, appveyor, r-hub before: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-49cecef3bb09db1db130db31604e0293/SparkR.Rcheck/00check.log after: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-86a066c7576f46794930ad114e5cff7c/SparkR.Rcheck/00check.log Author: Felix Cheung <felixcheung_m@hotmail.com> Closesapache#19016 from felixcheung/rvigwind.

## What changes were proposed in this pull request? Code in vignettes requires winutils on windows to run, when publishing to CRAN or building from source, winutils might not be available, so it's better to disable code run (so resulting vigenttes will not have output from code, but text is still there and code is still there) fix * checking re-building of vignette outputs ... WARNING and > %LOCALAPPDATA% not found. Please define the environment variable or restart and enter an installation path in localDir. ## How was this patch tested? jenkins, appveyor, r-hub before: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-49cecef3bb09db1db130db31604e0293/SparkR.Rcheck/00check.log after: https://artifacts.r-hub.io/SparkR_2.2.0.tar.gz-86a066c7576f46794930ad114e5cff7c/SparkR.Rcheck/00check.log Author: Felix Cheung <felixcheung_m@hotmail.com> Closesapache#19016 from felixcheung/rvigwind. (cherry picked from commit 43cbfad) Signed-off-by: Felix Cheung <felixcheung@apache.org>

felixcheung added 2 commits August 20, 2017 17:11

disable eval on windows
ba65d6e

add support for no localappdata
7c75073

felixcheung changed the title ~~[SPARK-21805] Disable R vignettes code on Windows~~[SPARK-21805][SPARKR] Disable R vignettes code on WindowsAug 22, 2017

felixcheung closed this Aug 23, 2017

felixcheung reopened this Aug 23, 2017

shivaram reviewed Aug 23, 2017
View reviewed changes

fix description
23f9d5e

asfgit closed this in 43cbfadAug 24, 2017

Uh oh!

Conversation

felixcheung commented Aug 22, 2017

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

SparkQA commented Aug 22, 2017

Uh oh!

HyukjinKwon commented Aug 22, 2017

Uh oh!

felixcheung commented Aug 22, 2017

Uh oh!

HyukjinKwon commented Aug 22, 2017

Uh oh!

SparkQA commented Aug 22, 2017

Uh oh!

shivaram commented Aug 23, 2017

Uh oh!

felixcheung commented Aug 23, 2017 via email

Uh oh!

shivaram commented Aug 23, 2017

Uh oh!

felixcheung commented Aug 23, 2017 via email

Uh oh!

shivaramAug 23, 2017

Choose a reason for hiding this comment

Uh oh!

felixcheungAug 23, 2017

Choose a reason for hiding this comment

Uh oh!

shivaram commented Aug 23, 2017

Uh oh!

SparkQA commented Aug 23, 2017

Uh oh!

HyukjinKwon commented Aug 23, 2017

Uh oh!

felixcheung commented Aug 24, 2017

Uh oh!

felixcheung commented Aug 25, 2017

Uh oh!

shivaram commented Aug 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants