Skip to content

[SPARK-21953] Show both memory and disk bytes spilled if either is present - #19164

Closed
ash211 wants to merge 1 commit into
apache:masterfrom
ash211:patch-3
Closed

[SPARK-21953] Show both memory and disk bytes spilled if either is present#19164
ash211 wants to merge 1 commit into
apache:masterfrom
ash211:patch-3

Conversation

@ash211

@ash211ash211 commented Sep 8, 2017

Copy link
Copy Markdown
Contributor

As written now, there must be both memory and disk bytes spilled to show either of them. If there is only one of those types of spill recorded, it will be hidden.

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA

Copy link
Copy Markdown

Test build #81549 has finished for PR 19164 at commit 7852abe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

kiszk commented Sep 8, 2017

Copy link
Copy Markdown
Member

LGTM

@ajbozarth

Copy link
Copy Markdown
Member

nice catch, LGTM

@jiangxb1987jiangxb1987 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asfgit pushed a commit that referenced this pull request Sep 18, 2017
…esent
As written now, there must be both memory and disk bytes spilled to show either of them. If there is only one of those types of spill recorded, it will be hidden.
Author: Andrew Ash <andrew@andrewash.com>
Closes#19164 from ash211/patch-3.
(cherry picked from commit 6308c65)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@cloud-fan

Copy link
Copy Markdown
Contributor

LGTM, merging to master/2.2/2.1!

asfgit pushed a commit that referenced this pull request Sep 18, 2017
…esent
As written now, there must be both memory and disk bytes spilled to show either of them. If there is only one of those types of spill recorded, it will be hidden.
Author: Andrew Ash <andrew@andrewash.com>
Closes#19164 from ash211/patch-3.
(cherry picked from commit 6308c65)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
…esent
As written now, there must be both memory and disk bytes spilled to show either of them. If there is only one of those types of spill recorded, it will be hidden.
Author: Andrew Ash <andrew@andrewash.com>
Closesapache#19164 from ash211/patch-3.
(cherry picked from commit 6308c65)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@ash211@SparkQA@kiszk@ajbozarth@cloud-fan@jiangxb1987@dongjoon-hyun