Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22076][SQL] Expand.projections should not be a Stream - #19289
Closed
cloud-fan wants to merge 1 commit into
Closed
[SPARK-22076][SQL] Expand.projections should not be a Stream#19289cloud-fan wants to merge 1 commit into
cloud-fan wants to merge 1 commit into
Conversation
cloud-fan
commented
Sep 20, 2017
ContributorAuthor
SparkQA
commented
Sep 20, 2017
Test build #81974 has finished for PR 19289 at commit
|
gatorsmile
commented
Sep 20, 2017
Member
retest this please |
SparkQA
commented
Sep 20, 2017
Test build #81977 has finished for PR 19289 at commit
|
SparkQA
commented
Sep 20, 2017
Test build #81979 has finished for PR 19289 at commit
|
asfgit pushed a commit
that referenced
this pull request
Sep 20, 2017
## What changes were proposed in this pull request?
Spark with Scala 2.10 fails with a group by cube:
```
spark.range(1).select($"id" as "a", $"id" as "b").write.partitionBy("a").mode("overwrite").saveAsTable("rollup_bug")
spark.sql("select 1 from rollup_bug group by rollup ()").show
```
It can be traced back to #15484 , which made `Expand.projections` a lazy `Stream` for group by cube.
In scala 2.10 `Stream` captures a lot of stuff, and in this case it captures the entire query plan which has some un-serializable parts.
This change is also good for master branch, to reduce the serialized size of `Expand.projections`.
## How was this patch tested?
manually verified with Spark with Scala 2.10.
Author: Wenchen Fan <wenchen@databricks.com>
Closes#19289 from cloud-fan/bug.
(cherry picked from commit ce6a71e)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>Member
LGTM Thanks! Merged to master/2.2. |
ghost
pushed a commit
to dbtsai/spark
that referenced
this pull request
Sep 21, 2017
## What changes were proposed in this pull request? This a follow-up of apache#19289 , we missed another place: `rollup`. `Seq.init.toSeq` also returns a `Stream`, we should fix it too. ## How was this patch tested? manually Author: Wenchen Fan <wenchen@databricks.com> Closesapache#19298 from cloud-fan/bug.
MatthewRBruce pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
## What changes were proposed in this pull request?
Spark with Scala 2.10 fails with a group by cube:
```
spark.range(1).select($"id" as "a", $"id" as "b").write.partitionBy("a").mode("overwrite").saveAsTable("rollup_bug")
spark.sql("select 1 from rollup_bug group by rollup ()").show
```
It can be traced back to apache#15484 , which made `Expand.projections` a lazy `Stream` for group by cube.
In scala 2.10 `Stream` captures a lot of stuff, and in this case it captures the entire query plan which has some un-serializable parts.
This change is also good for master branch, to reduce the serialized size of `Expand.projections`.
## How was this patch tested?
manually verified with Spark with Scala 2.10.
Author: Wenchen Fan <wenchen@databricks.com>
Closesapache#19289 from cloud-fan/bug.
(cherry picked from commit ce6a71e)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Spark with Scala 2.10 fails with a group by cube:
It can be traced back to #15484 , which made
Expand.projectionsa lazyStreamfor group by cube.In scala 2.10
Streamcaptures a lot of stuff, and in this case it captures the entire query plan which has some un-serializable parts.This change is also good for master branch, to reduce the serialized size of
Expand.projections.How was this patch tested?
manually verified with Spark with Scala 2.10.