Skip to content

[SPARK-22107] Change as to alias in python quickstart - #19326

Closed
jgoleary wants to merge 1 commit into
apache:masterfrom
jgoleary:issues/22107
Closed

[SPARK-22107] Change as to alias in python quickstart#19326
jgoleary wants to merge 1 commit into
apache:masterfrom
jgoleary:issues/22107

Conversation

@jgoleary

@jgolearyjgoleary commented Sep 22, 2017•
edited
Loading

Copy link
Copy Markdown

What changes were proposed in this pull request?

Updated docs so that a line of python in the quick start guide executes. Closes#19283

How was this patch tested?

Existing tests.

@HyukjinKwon

HyukjinKwon commented Sep 23, 2017

Copy link
Copy Markdown
Member

How does it relate to #19283?

@jgoleary

jgoleary commented Sep 23, 2017

Copy link
Copy Markdown
Author

@HyukjinKwon looks like this does the same thing as name() is an alias for alias(). Happy to close but suggest merging one of these to help future noobs.

@HyukjinKwon

HyukjinKwon commented Sep 24, 2017

Copy link
Copy Markdown
Member

That's fine. I believe we don't usually need a JIRA for a trivial change though. Would you mind double checking if there are similar instances in the PySpark doc?

Also, it'd be great if we add Closes #19283 in the PR description so that #19283 can be automatically closed when this PR is merged. It looks #19283 has gone inactive.

@jgoleary

jgoleary commented Sep 24, 2017

Copy link
Copy Markdown
Author

Updated description. The only other mentions of as() I can find in the docs are in Java examples, and the method appears to exist on the Java side.

@HyukjinKwon

HyukjinKwon commented Sep 24, 2017

Copy link
Copy Markdown
Member

ok to test

@SparkQA

SparkQA commented Sep 24, 2017

Copy link
Copy Markdown

Test build #82139 has finished for PR 19326 at commit c6bf156.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Sep 25, 2017
@jgoleary@HyukjinKwon
[SPARK-22107] Change as to alias in python quickstart
8acce00
## What changes were proposed in this pull request?
Updated docs so that a line of python in the quick start guide executes. Closes#19283
## How was this patch tested?
Existing tests.
Author: John O'Leary <jgoleary@gmail.com>
Closes#19326 from jgoleary/issues/22107.
(cherry picked from commit 20adf9a)
Signed-off-by: hyukjinkwon <gurwls223@gmail.com>
@HyukjinKwon

HyukjinKwon commented Sep 25, 2017

Copy link
Copy Markdown
Member

Merged to master and branch-2.2.

@jgoleary, I merged this considering the first contribution but let's do this in a batch if possible in the future.

MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
@jgoleary@MatthewRBruce
[SPARK-22107] Change as to alias in python quickstart
544a18d
## What changes were proposed in this pull request?
Updated docs so that a line of python in the quick start guide executes. Closesapache#19283
## How was this patch tested?
Existing tests.
Author: John O'Leary <jgoleary@gmail.com>
Closesapache#19326 from jgoleary/issues/22107.
(cherry picked from commit 20adf9a)
Signed-off-by: hyukjinkwon <gurwls223@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwonHyukjinKwonHyukjinKwon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jgoleary@HyukjinKwon@SparkQA