Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22416][SQL] Move OrcOptions from sql/hive to sql/core - #19636
Closed
dongjoon-hyun wants to merge 3 commits into
Closed
[SPARK-22416][SQL] Move OrcOptions from sql/hive to sql/core#19636dongjoon-hyun wants to merge 3 commits into
sql/hive to sql/core#19636dongjoon-hyun wants to merge 3 commits into
Conversation
SparkQA
commented
Nov 1, 2017
Test build #83306 has started for PR 19636 at commit |
dongjoon-hyun
commented
Nov 1, 2017
MemberAuthor
Retest this please. |
SparkQA
commented
Nov 1, 2017
Test build #83308 has started for PR 19636 at commit |
| * Options for the ORC data source. | ||
| */ | ||
| private[orc] class OrcOptions( | ||
| private[sql] class OrcOptions( |
Member
There was a problem hiding this comment.
I believe private[sql] can be removed per SPARK-16964.
dongjoon-hyun
commented
Nov 2, 2017
MemberAuthor
Retest this please. |
1 similar comment
dongjoon-hyun
commented
Nov 2, 2017
MemberAuthor
Retest this please. |
dongjoon-hyun
commented
Nov 2, 2017
MemberAuthor
Thank you for review, @jiangxb1987 . |
SparkQA
commented
Nov 2, 2017
Test build #83317 has finished for PR 19636 at commit
|
dongjoon-hyun
commented
Nov 2, 2017
MemberAuthor
Hi, @cloud-fan and @gatorsmile . |
cloud-fan
commented
Nov 2, 2017
Contributor
LGTM, merging to master! |
dongjoon-hyun
commented
Nov 2, 2017
MemberAuthor
Thank you so much, @cloud-fan , @HyukjinKwon , and @jiangxb1987 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
According to the discussion on SPARK-15474, we will add new OrcFileFormat in
sql/coremodule and allow users to use both old and new OrcFileFormat.To do that,
OrcOptionsshould be visible insql/coremodule, too. Previously, it wasprivate[orc]insql/hive. This PR removesprivate[orc]because we don't useprivate[sql]insql/executionpackage after SPARK-16964.How was this patch tested?
Pass the Jenkins with the existing tests.