Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from SaveintoDataSourceCommand.simpleString - #19761
Closed
onursatici wants to merge 3 commits into
Closed
[SPARK-22479][SQL][BRANCH-2.2] Exclude credentials from SaveintoDataSourceCommand.simpleString#19761onursatici wants to merge 3 commits into
onursatici wants to merge 3 commits into
Conversation
onursatici
commented
Nov 15, 2017
ContributorAuthor
follow-up of #19708 |
gatorsmile
commented
Nov 16, 2017
Member
ok to test |
| override def simpleString: String = { | ||
| val redacted = Utils.redact(SparkEnv.get.conf, options.toSeq).toMap | ||
| s"SaveIntoDataSourceCommand ${dataSource}, ${redacted}, ${mode}" |
Member
There was a problem hiding this comment.
dataSource does not exist in 2.2
SparkQA
commented
Nov 16, 2017
Test build #83922 has finished for PR 19761 at commit
|
SparkQA
commented
Nov 16, 2017
Test build #83923 has finished for PR 19761 at commit
|
SparkQA
commented
Nov 16, 2017
Test build #83924 has finished for PR 19761 at commit
|
cloud-fan
commented
Nov 16, 2017
Contributor
thanks, merging to 2.2! |
asfgit pushed a commit
that referenced
this pull request
Nov 16, 2017
…ourceCommand.simpleString ## What changes were proposed in this pull request? Do not include jdbc properties which may contain credentials in logging a logical plan with `SaveIntoDataSourceCommand` in it. ## How was this patch tested? new tests Author: osatici <osatici@palantir.com> Closes#19761 from onursatici/os/redact-jdbc-creds-2.2.
gatorsmile
commented
Nov 17, 2017
Member
@onursatici Could you please close it? |
jiangxb1987
commented
Nov 20, 2017
Contributor
ping @onursatici |
MatthewRBruce pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…ourceCommand.simpleString ## What changes were proposed in this pull request? Do not include jdbc properties which may contain credentials in logging a logical plan with `SaveIntoDataSourceCommand` in it. ## How was this patch tested? new tests Author: osatici <osatici@palantir.com> Closesapache#19761 from onursatici/os/redact-jdbc-creds-2.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Do not include jdbc properties which may contain credentials in logging a logical plan with
SaveIntoDataSourceCommandin it.How was this patch tested?
new tests