Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22520][SQL][followup] remove outer if for case when codegen - #19830
Closed
cloud-fan wants to merge 1 commit into
Closed
[SPARK-22520][SQL][followup] remove outer if for case when codegen#19830cloud-fan wants to merge 1 commit into
cloud-fan wants to merge 1 commit into
Conversation
cloud-fan
commented
Nov 28, 2017
ContributorAuthor
mgaido91
commented
Nov 28, 2017
Contributor
LGTM, thanks for the fix! |
SparkQA
commented
Nov 28, 2017
Test build #84249 has finished for PR 19830 at commit
|
cloud-fan
commented
Nov 28, 2017
ContributorAuthor
thanks, merging to master! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
a minor cleanup for #19752 . Remove the outer if as the code is inside
do whileHow was this patch tested?
existing tests