Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22672][TEST][SQL] Move OrcTest to sql/core - #19863
Conversation
SparkQA
commented
Dec 2, 2017
Test build #84381 has finished for PR 19863 at commit
|
| import org.apache.spark.sql.test.SQLTestUtils | ||
| private[sql] trait OrcTest extends SQLTestUtils with TestHiveSingleton { | ||
| abstract class OrcTest extends QueryTest with SQLTestUtils { |
There was a problem hiding this comment.
When we have not moved the test suites of ORC, why we need to move this out of Hive now?
There was a problem hiding this comment.
Unlike the previous ORC PRs, #19651 intentionally uses the existing old Hive tests suites. This PR is a preparation for moving test cases.
There was a problem hiding this comment.
Since this PR is tiny, we can do it when the other PRs are merged.
There was a problem hiding this comment.
As you see, we can do this without merging other ORC PRs, and this will reduce the scope of review for the other PRs.
dongjoon-hyun
commented
Dec 3, 2017
@gatorsmile . Since the main PR is merged, I'll include this into the others. Thanks! |
What changes were proposed in this pull request?
To support ORC tests without Hive, we had better have
OrcTestinsql/coreinstead ofsql/hive.How was this patch tested?
This is a test suite only change. It should pass all existing tests.