Uh oh!
There was an error while loading. Please reload this page.
[SPARK-21168] KafkaRDD should always set kafka clientId. - #19887
Closed
liu-zhaokun wants to merge 1 commit into
Closed
[SPARK-21168] KafkaRDD should always set kafka clientId.#19887liu-zhaokun wants to merge 1 commit into
liu-zhaokun wants to merge 1 commit into
Conversation
liu-zhaokun
commented
Mar 19, 2018
ContributorAuthor
Can one of the admins verify this patch? |
SparkQA
commented
Apr 18, 2018
Test build #4153 has finished for PR 19887 at commit
|
srowen
commented
Apr 23, 2018
Member
Seems reasonable; maybe @koeninger has a thought |
koeninger
commented
Apr 23, 2018
Contributor
Jenkins, retest this please |
koeninger
commented
Apr 23, 2018
Contributor
Seems ok to me, long as it passes retest |
SparkQA
commented
Apr 23, 2018
Test build #89733 has finished for PR 19887 at commit
|
koeninger
commented
Apr 23, 2018
Contributor
Merging to master, thanks @liu-zhaokun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-21168
There are no a number of other places that a client ID should be set,and I think we should use consumer.clientId in the clientId method,because the fetch request will be used by the same consumer behind.