Uh oh!
There was an error while loading. Please reload this page.
[SPARK-3085] [SQL] Use compact data structures in SQL joins - #1993
Closed
mateiz wants to merge 2 commits into
Closed
[SPARK-3085] [SQL] Use compact data structures in SQL joins#1993mateiz wants to merge 2 commits into
mateiz wants to merge 2 commits into
Conversation
This reuses the CompactBuffer from Spark Core to save memory and pointer dereferences. I also tried AppendOnlyMap instead of java.util.HashMap but unfortunately that slows things down because it seems to do more equals() calls and the equals on GenericRow, and especially JoinedRow, is pretty expensive.
SparkQA
commented
Aug 17, 2014
QA tests have started for PR 1993 at commit
|
SparkQA
commented
Aug 17, 2014
QA tests have finished for PR 1993 at commit
|
mateiz
commented
Aug 17, 2014
ContributorAuthor
Jenkins, retest this please |
SparkQA
commented
Aug 17, 2014
QA tests have started for PR 1993 at commit
|
SparkQA
commented
Aug 17, 2014
QA tests have finished for PR 1993 at commit
|
Contributor
There was a problem hiding this comment.
We aren't actually using AppendOnlyMap though right?
ContributorAuthor
There was a problem hiding this comment.
Ah true, I'll remove the import
SparkQA
commented
Aug 18, 2014
QA tests have started for PR 1993 at commit
|
SparkQA
commented
Aug 18, 2014
QA tests have finished for PR 1993 at commit
|
marmbrus
commented
Aug 18, 2014
Contributor
Looking at the various runs, this patch only failed the thrift server tests consistently, so I'm going to go ahead and merge it. Thanks matei. |
asfgit pushed a commit
that referenced
this pull request
Aug 18, 2014
This reuses the CompactBuffer from Spark Core to save memory and pointer dereferences. I also tried AppendOnlyMap instead of java.util.HashMap but unfortunately that slows things down because it seems to do more equals() calls and the equals on GenericRow, and especially JoinedRow, is pretty expensive. Author: Matei Zaharia <matei@databricks.com> Closes#1993 from mateiz/spark-3085 and squashes the following commits: 188221e [Matei Zaharia] Remove unneeded import 5f903ee [Matei Zaharia] [SPARK-3085] [SQL] Use compact data structures in SQL joins (cherry picked from commit 4bf3de7) Signed-off-by: Michael Armbrust <michael@databricks.com>
xiliu82 pushed a commit
to xiliu82/spark
that referenced
this pull request
Sep 4, 2014
This reuses the CompactBuffer from Spark Core to save memory and pointer dereferences. I also tried AppendOnlyMap instead of java.util.HashMap but unfortunately that slows things down because it seems to do more equals() calls and the equals on GenericRow, and especially JoinedRow, is pretty expensive. Author: Matei Zaharia <matei@databricks.com> Closesapache#1993 from mateiz/spark-3085 and squashes the following commits: 188221e [Matei Zaharia] Remove unneeded import 5f903ee [Matei Zaharia] [SPARK-3085] [SQL] Use compact data structures in SQL joins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reuses the CompactBuffer from Spark Core to save memory and pointer
dereferences. I also tried AppendOnlyMap instead of java.util.HashMap
but unfortunately that slows things down because it seems to do more
equals() calls and the equals on GenericRow, and especially JoinedRow,
is pretty expensive.