Skip to content

[SPARK-22672][SQL][TEST][FOLLOWUP] Fix to use spark.conf - #19931

Closed
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-22672-2
Closed

[SPARK-22672][SQL][TEST][FOLLOWUP] Fix to use spark.conf#19931
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-22672-2

Conversation

@dongjoon-hyun

@dongjoon-hyundongjoon-hyun commented Dec 9, 2017

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

During #19882, conf is mistakenly used to switch ORC implementation between native and hive. To affect OrcTest correctly, spark.conf should be used.

How was this patch tested?

Pass the tests.

@SparkQA

Copy link
Copy Markdown

Test build #84673 has finished for PR 19931 at commit b4b1122.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

Retest this please

@SparkQA

Copy link
Copy Markdown

Test build #84678 has finished for PR 19931 at commit b4b1122.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

Copy link
Copy Markdown
Member

Merged to master.

@asfgitasfgit closed this in 251b2c0Dec 9, 2017
@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

Oh, thank you so much, @HyukjinKwon .

@dongjoon-hyun
dongjoon-hyun deleted the SPARK-22672-2 branch December 9, 2017 16:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dongjoon-hyun@SparkQA@HyukjinKwon