Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22866] [K8S] Fix path issue in Kubernetes dockerfile - #20051
[SPARK-22866] [K8S] Fix path issue in Kubernetes dockerfile#20051foxish wants to merge 2 commits into
Conversation
The path was recently changed in apache#19946, but the dockerfile was not updated.
| COPY sbin /opt/spark/sbin | ||
| COPY conf /opt/spark/conf | ||
| COPY dockerfiles/spark-base/entrypoint.sh /opt/ | ||
| COPY kubernetes/dockerfiles/spark-base/entrypoint.sh /opt/ |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, to elaborate, on our fork, we used to have dockerfiles/ in the root of the built distribution. But now, it's copied to kubernetes/dockerfiles which is a more logical place, since there is a yarn/ in the distribution as well.
A grep indicates this is the full list:
|
foxish
commented
Dec 22, 2017
@mridulm thanks for looking into it! Looks like I missed updating the dockerfile comments. On it. |
Done, comments updated. I'm setting up CI on the Kubernetes test infrastructure this week - should help catch these issues early on in future. |
mridulm
commented
Dec 22, 2017
Merged, thanks @foxish |
SparkQA
commented
Dec 22, 2017
Test build #85294 has finished for PR 20051 at commit
|
SparkQA
commented
Dec 22, 2017
Test build #85297 has finished for PR 20051 at commit
|
What changes were proposed in this pull request?
The path was recently changed in #19946, but the dockerfile was not updated.
This is a trivial 1 line fix.
How was this patch tested?
./sbin/build-push-docker-images.sh -r spark-repo -t latest buildcc/ @vanzin@mridulm@rxin@jiangxb1987@liyinan926