Uh oh!
There was an error while loading. Please reload this page.
[SPARK-22905][MLLIB] Fix ChiSqSelectorModel save implementation - #20088
[SPARK-22905][MLLIB] Fix ChiSqSelectorModel save implementation#20088WeichenXu123 wants to merge 1 commit into
Conversation
WeichenXu123
commented
Dec 27, 2017
Currently I cannot construct a failed test for this issue, but the future PR (changing |
SparkQA
commented
Dec 27, 2017
Test build #85422 has finished for PR 20088 at commit
|
jiangxb1987
left a comment
There was a problem hiding this comment.
LGTM, if we want to keep the output sequence then it is recommended to avoid performing repartition() without extra sort, because the repartition() function doesn't guarantee that sequence is kept.
We should also fix other similar places where we perform a repartition() during save().
jkbradley
commented
Dec 28, 2017
This is hopefully a rare case of an error in assuming an ordering of rows; in general, we shouldn't (and don't, AFAIK) assume an order for rows in saving/loading models. LGTM, but before this is merged, can you please remove the ML and CORE tags from the PR title @WeichenXu123 ? |
jkbradley
commented
Dec 28, 2017
Merging with master |
What changes were proposed in this pull request?
Currently, in
ChiSqSelectorModel, save:The default partition number used by createDataFrame is "defaultParallelism",
Current RoundRobinPartitioning won't guarantee the "repartition" generating the same order result with local array. We need fix it.
How was this patch tested?
N/A