[SPARK-22932] [SQL] Refactor AnalysisContext by gatorsmile · Pull Request #20127 · apache/spark

gatorsmile · 2017-12-31T13:30:29Z

What changes were proposed in this pull request?

Add a reset function to ensure the state in AnalysisContext is per-query.

How was this patch tested?

The existing test cases

gatorsmile · 2017-12-31T13:31:36Z

cc @cloud-fan @jiangxb1987

SparkQA · 2017-12-31T15:47:38Z

Test build #85557 has finished for PR 20127 at commit f158a95.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

kiszk · 2017-12-31T16:47:58Z

retest this please

SparkQA · 2017-12-31T19:36:39Z

Test build #85562 has finished for PR 20127 at commit f158a95.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

kiszk · 2018-01-01T02:35:15Z

retest this please

SparkQA · 2018-01-01T05:42:58Z

Test build #85570 has finished for PR 20127 at commit f158a95.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

viirya

I think AnalysisContext is already per-query for now, because only withAnalysisContext can change it.

Seems this just adds another safety guard.

viirya · 2018-01-01T08:07:03Z

+ }
+ }
+
+ private def executeSameContext(plan: LogicalPlan): LogicalPlan = super.execute(plan)


executeWithSameContext?

viirya · 2018-01-01T08:11:51Z

 }

 def get: AnalysisContext = value.get()
+ def reset(): Unit = value.remove()


Will be resolved by the future PR.

jiangxb1987 · 2018-01-01T17:29:08Z

lgtm

gatorsmile · 2018-01-02T01:18:27Z

Thanks! Merged to master

dongjoon-hyun · 2018-01-02T21:52:06Z

Hi, @gatorsmile .
This PR seems to land into only master, but is marked as 2.3.0 in JIRA.
Could you merge this into branch-2.3 or fix the version into 2.4 or 3.0?

## What changes were proposed in this pull request? Add a `reset` function to ensure the state in `AnalysisContext ` is per-query. ## How was this patch tested? The existing test cases Author: gatorsmile <gatorsmile@gmail.com> Closes#20127 from gatorsmile/refactorAnalysisContext.

gatorsmile · 2018-01-03T17:01:06Z

Yeah, I manually merged it to 2.3 branch.

refactor
f158a95

viirya reviewed Jan 1, 2018
View reviewed changes

asfgit closed this in e0c090fJan 2, 2018

Uh oh!

Conversation

gatorsmile commented Dec 31, 2017

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

gatorsmile commented Dec 31, 2017

Uh oh!

SparkQA commented Dec 31, 2017

Uh oh!

kiszk commented Dec 31, 2017

Uh oh!

SparkQA commented Dec 31, 2017

Uh oh!

kiszk commented Jan 1, 2018

Uh oh!

SparkQA commented Jan 1, 2018

Uh oh!

viirya left a comment

Choose a reason for hiding this comment

Uh oh!

viiryaJan 1, 2018

Choose a reason for hiding this comment

Uh oh!

cloud-fanJan 2, 2018

Choose a reason for hiding this comment

Uh oh!

viiryaJan 1, 2018

Choose a reason for hiding this comment

Uh oh!

gatorsmileJan 2, 2018

Choose a reason for hiding this comment

Uh oh!

jiangxb1987 commented Jan 1, 2018

Uh oh!

gatorsmile commented Jan 2, 2018

Uh oh!

dongjoon-hyun commented Jan 2, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gatorsmile commented Jan 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dongjoon-hyun commented Jan 2, 2018•
edited
Loading