Skip to content

[SPARK-22771][SQL] Add a missing return statement in Concat.checkInputDataTypes - #20149

Closed
maropu wants to merge 1 commit into
apache:masterfrom
maropu:SPARK-22771-FOLLOWUP
Closed

[SPARK-22771][SQL] Add a missing return statement in Concat.checkInputDataTypes#20149
maropu wants to merge 1 commit into
apache:masterfrom
maropu:SPARK-22771-FOLLOWUP

Conversation

@maropu

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This pr is a follow-up to fix a bug left in #19977.

How was this patch tested?

Added tests in StringExpressionsSuite.

@maropu

Copy link
Copy Markdown
MemberAuthor

cc: @gatorsmile

@SparkQA

Copy link
Copy Markdown

Test build #85665 has finished for PR 20149 at commit 2b385ac.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu

Copy link
Copy Markdown
MemberAuthor

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #85672 has finished for PR 20149 at commit 2b385ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmilegatorsmile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile

Copy link
Copy Markdown
Member

Thanks! Merged to master and 2.3

asfgit pushed a commit that referenced this pull request Jan 4, 2018
…tDataTypes
## What changes were proposed in this pull request?
This pr is a follow-up to fix a bug left in #19977.
## How was this patch tested?
Added tests in `StringExpressionsSuite`.
Author: Takeshi Yamamuro <yamamuro@apache.org>
Closes#20149 from maropu/SPARK-22771-FOLLOWUP.
(cherry picked from commit 6f68316)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>
@asfgitasfgit closed this in 6f68316Jan 4, 2018
@maropu

Copy link
Copy Markdown
MemberAuthor

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@maropu@SparkQA@gatorsmile