Uh oh!
There was an error while loading. Please reload this page.
[SPARK-23192] [SQL] Keep the Hint after Using Cached Data - #20365
Closed
gatorsmile wants to merge 2 commits into
Closed
[SPARK-23192] [SQL] Keep the Hint after Using Cached Data#20365gatorsmile wants to merge 2 commits into
gatorsmile wants to merge 2 commits into
Conversation
gatorsmile
commented
Jan 23, 2018
MemberAuthor
sameeragarwal
commented
Jan 23, 2018
Member
LGTM |
jiangxb1987
approved these changes
Jan 23, 2018
SparkQA
commented
Jan 23, 2018
Test build #86536 has finished for PR 20365 at commit
|
jiangxb1987
commented
Jan 23, 2018
Contributor
retest this please |
SparkQA
commented
Jan 23, 2018
Test build #86544 has finished for PR 20365 at commit
|
gatorsmile
commented
Jan 23, 2018
MemberAuthor
Since the last change is just to change the test case name, I merge this PR. |
gatorsmile
commented
Jan 23, 2018
MemberAuthor
Thanks! Merged to master/2.3 |
asfgit pushed a commit
that referenced
this pull request
Jan 23, 2018
## What changes were proposed in this pull request?
The hint of the plan segment is lost, if the plan segment is replaced by the cached data.
```Scala
val df1 = spark.createDataFrame(Seq((1, "4"), (2, "2"))).toDF("key", "value")
val df2 = spark.createDataFrame(Seq((1, "1"), (2, "2"))).toDF("key", "value")
df2.cache()
val df3 = df1.join(broadcast(df2), Seq("key"), "inner")
```
This PR is to fix it.
## How was this patch tested?
Added a test
Author: gatorsmile <gatorsmile@gmail.com>
Closes#20365 from gatorsmile/fixBroadcastHintloss.
(cherry picked from commit 613c290)
Signed-off-by: gatorsmile <gatorsmile@gmail.com>SparkQA
commented
Jan 24, 2018
Test build #86546 has finished for PR 20365 at commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The hint of the plan segment is lost, when the plan segment is replaced by the cached data.
This PR is to fix it.
How was this patch tested?
Added a test