Skip to content

[SPARK-23261][PYSPARK][BACKPORT-2.3] Rename Pandas UDFs - #20439

Closed
gatorsmile wants to merge 1 commit into
apache:branch-2.3from
gatorsmile:backport2.3
Closed

[SPARK-23261][PYSPARK][BACKPORT-2.3] Rename Pandas UDFs#20439
gatorsmile wants to merge 1 commit into
apache:branch-2.3from
gatorsmile:backport2.3

Conversation

@gatorsmile

@gatorsmilegatorsmile commented Jan 30, 2018

Copy link
Copy Markdown
Member

This PR is to backport #20428 to Spark 2.3 without adding the changes regarding GROUPED AGG PANDAS UDF


What changes were proposed in this pull request?

Rename the public APIs and names of pandas udfs.

  • PANDAS SCALAR UDF -> SCALAR PANDAS UDF
  • PANDAS GROUP MAP UDF -> GROUPED MAP PANDAS UDF

How was this patch tested?

The existing tests

Rename the public APIs and names of pandas udfs.
- `PANDAS SCALAR UDF` -> `SCALAR PANDAS UDF`
- `PANDAS GROUP MAP UDF` -> `GROUPED MAP PANDAS UDF`
- `PANDAS GROUP AGG UDF` -> `GROUPED AGG PANDAS UDF`
The existing tests
Author: gatorsmile <gatorsmile@gmail.com>
Closesapache#20428 from gatorsmile/renamePandasUDFs.
@gatorsmile

Copy link
Copy Markdown
MemberAuthor

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@BryanCutlerBryanCutler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA

Copy link
Copy Markdown

Test build #86841 has finished for PR 20439 at commit 1a70ae1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jan 31, 2018
This PR is to backport #20428 to Spark 2.3 without adding the changes regarding `GROUPED AGG PANDAS UDF`
---
## What changes were proposed in this pull request?
Rename the public APIs and names of pandas udfs.
- `PANDAS SCALAR UDF` -> `SCALAR PANDAS UDF`
- `PANDAS GROUP MAP UDF` -> `GROUPED MAP PANDAS UDF`
## How was this patch tested?
The existing tests
Author: gatorsmile <gatorsmile@gmail.com>
Closes#20439 from gatorsmile/backport2.3.
@gatorsmile

Copy link
Copy Markdown
MemberAuthor

Thanks! Merged to 2.3.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@gatorsmile@SparkQA@icexelloss@BryanCutler@HyukjinKwon@dongjoon-hyun