Uh oh!
There was an error while loading. Please reload this page.
[SPARK-23421] [SQL] Document the behavior change in SPARK-22356 - #20606
[SPARK-23421] [SQL] Document the behavior change in SPARK-22356#20606gatorsmile wants to merge 1 commit into
Conversation
gatorsmile
commented
Feb 14, 2018
cc @cloud-fan |
SparkQA
commented
Feb 14, 2018
Test build #87442 has finished for PR 20606 at commit
|
kiszk
commented
Feb 14, 2018
Retest this please |
SparkQA
commented
Feb 14, 2018
Test build #87448 has finished for PR 20606 at commit
|
| object PROCESS_TABLES extends QueryTest with SQLTestUtils { | ||
| // Tests the latest version of every release line. | ||
| val testingVersions = Seq("2.0.2", "2.1.2", "2.2.0") | ||
| val testingVersions = Seq("2.0.2", "2.1.2", "2.2.0", "2.2.1") |
There was a problem hiding this comment.
Please don't mix this into a PR with title Document.
There was a problem hiding this comment.
This is to verify what we explained in doc is correct.
There was a problem hiding this comment.
Yep. Please update the title to include that, too.
There was a problem hiding this comment.
Already has it in the PR description.
There was a problem hiding this comment.
The main goal of this PR is not to test it but to document it. We need another backport PR to SPARK 2.2 without the test.
cloud-fan
commented
Feb 15, 2018
LGTM |
## What changes were proposed in this pull request? #19579 introduces a behavior change. We need to document it in the migration guide. ## How was this patch tested? Also update the HiveExternalCatalogVersionsSuite to verify it. Author: gatorsmile <gatorsmile@gmail.com> Closes#20606 from gatorsmile/addMigrationGuide. (cherry picked from commit a77ebb0) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
gatorsmile
commented
Feb 15, 2018
Thanks! Merged to master/2.3 |
What changes were proposed in this pull request?
#19579 introduces a behavior change. We need to document it in the migration guide.
How was this patch tested?
Also update the HiveExternalCatalogVersionsSuite to verify it.