Uh oh!
There was an error while loading. Please reload this page.
[SPARK-23795][LAUNCHER] Make AbstractLauncher#self() protected - #20905
Closed
dansanduleac wants to merge 1 commit into
Closed
[SPARK-23795][LAUNCHER] Make AbstractLauncher#self() protected#20905dansanduleac wants to merge 1 commit into
dansanduleac wants to merge 1 commit into
Conversation
AmplabJenkins
commented
Mar 26, 2018
Can one of the admins verify this patch? |
vanzin
commented
Mar 26, 2018
Contributor
See bug update. Please close this PR. |
rshkv pushed a commit
to palantir/spark
that referenced
this pull request
Feb 23, 2021
[1] https://issues.apache.org/jira/browse/SPARK-23795 [2] apache#20905 Co-authored-by: Dan Sănduleac <dansanduleac@users.noreply.github.com> Co-authored-by: Josh Casale <jcasale@palantir.com> Co-authored-by: Will Raschkowski <wraschkowski@palantir.com>
zifeif2 pushed a commit
to zifeif2/spark
that referenced
this pull request
Nov 22, 2025
Closesapache#20458Closesapache#20530Closesapache#20557Closesapache#20966Closesapache#20857Closesapache#19694Closesapache#18227Closesapache#20683Closesapache#20881Closesapache#20347Closesapache#20825Closesapache#20078Closesapache#21281Closesapache#19951Closesapache#20905Closesapache#20635 Author: Sean Owen <srowen@gmail.com> Closesapache#21303 from srowen/ClosePRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make
AbstractLauncher#self()protected.The class is
public abstractbut becauseself()is package-private, it cannot actually be implemented, which seems like an oversight.How was this patch tested?
palantir#341