Skip to content

[SPARK-23794][SQL] Make UUID as stateful expression - #20912

Closed
viirya wants to merge 1 commit into
apache:masterfrom
viirya:SPARK-23794
Closed

[SPARK-23794][SQL] Make UUID as stateful expression#20912
viirya wants to merge 1 commit into
apache:masterfrom
viirya:SPARK-23794

Conversation

@viirya

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

The UUID() expression is stateful and should implement the Stateful trait instead of the Nondeterministic trait.

How was this patch tested?

Added test.

@viirya

Copy link
Copy Markdown
MemberAuthor

cc @hvanhovell

@hvanhovellhvanhovell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending jenkins

@SparkQA

Copy link
Copy Markdown

Test build #88625 has finished for PR 20912 at commit c9e70ed.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class Uuid(randomSeed: Option[Long] = None) extends LeafExpression with Stateful

@hvanhovell

Copy link
Copy Markdown
Contributor

Merging to master. Thanks for the quick turnaround!

@hvanhovell

Copy link
Copy Markdown
Contributor

@viirya

Copy link
Copy Markdown
MemberAuthor

Seems it didn't show up in github's commit?

@hvanhovell

Copy link
Copy Markdown
Contributor

The workflow is that we merge to apache git, and that the commit get pushed to github via some synchronization. Apparently the latter is broken.

@hvanhovell

Copy link
Copy Markdown
Contributor

wow that only took 8 hours....

mshtelma pushed a commit to mshtelma/spark that referenced this pull request Apr 5, 2018
## What changes were proposed in this pull request?
The UUID() expression is stateful and should implement the `Stateful` trait instead of the `Nondeterministic` trait.
## How was this patch tested?
Added test.
Author: Liang-Chi Hsieh <viirya@gmail.com>
Closesapache#20912 from viirya/SPARK-23794.
@viirya
viirya deleted the SPARK-23794 branch December 27, 2023 18:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@viirya@SparkQA@hvanhovell