Skip to content

[SPARK-23892][Test] Improve converge and fix lint error in UTF8String-related tests - #21000

Closed
kiszk wants to merge 1 commit into
apache:masterfrom
kiszk:SPARK-23892
Closed

[SPARK-23892][Test] Improve converge and fix lint error in UTF8String-related tests#21000
kiszk wants to merge 1 commit into
apache:masterfrom
kiszk:SPARK-23892

Conversation

@kiszk

@kiszkkiszk commented Apr 7, 2018

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This PR improves test coverage in UTF8StringSuite and code efficiency in UTF8StringPropertyCheckSuite.

This PR also fixes lint-java issue in UTF8StringSuite reported at here

[ERROR] src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:[28,8] (imports) UnusedImports: Unused import - org.apache.spark.unsafe.Platform.

How was this patch tested?

Existing UT

@kiszk

kiszk commented Apr 7, 2018

Copy link
Copy Markdown
MemberAuthor

@SparkQA

Copy link
Copy Markdown

Test build #89006 has finished for PR 21000 at commit 367dd4f.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

kiszk commented Apr 7, 2018

Copy link
Copy Markdown
MemberAuthor

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #89008 has finished for PR 21000 at commit 367dd4f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

kiszk commented Apr 7, 2018

Copy link
Copy Markdown
MemberAuthor

Or, is it better to change from

assertTrue(s1.startsWith(s1));
assertTrue(s1.endsWith(s1));

to

assertTrue(s1.startsWith(s1));
assertTrue(s1.endsWith(s1));
assertTrue(s2.startsWith(s2));
assertTrue(s2.endsWith(s2));
assertTrue(s1.startsWith(s2));
assertTrue(s1.endsWith(s2));
assertTrue(s2.startsWith(s1));
assertTrue(s2.endsWith(s1));

?

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. LGTM

@hvanhovell

Copy link
Copy Markdown
Contributor

LGTM - merging to master. Thanks!

@asfgitasfgit closed this in 710a68cApr 8, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kiszk@SparkQA@hvanhovell@srowen@HyukjinKwon