Uh oh!
There was an error while loading. Please reload this page.
[SPARK-19724][SQL][FOLLOW-UP]Check location of managed table when ignoreIfExists is true - #21001
[SPARK-19724][SQL][FOLLOW-UP]Check location of managed table when ignoreIfExists is true#21001gengliangwang wants to merge 1 commit into
Conversation
gengliangwang
commented
Apr 7, 2018
SparkQA
commented
Apr 7, 2018
Test build #89011 has finished for PR 21001 at commit
|
gengliangwang
commented
Apr 7, 2018
retest this please. |
SparkQA
commented
Apr 7, 2018
Test build #89017 has finished for PR 21001 at commit
|
SparkQA
commented
Apr 9, 2018
Test build #89050 has finished for PR 21001 at commit
|
There was a problem hiding this comment.
The error message is
"Table or view 'tbl' already exists in database 'default';"
This is soft of behavior change, as we check table existence first.
There was a problem hiding this comment.
Instead of deleting the test, we should change the name of the table
There was a problem hiding this comment.
We check table existence in SessionCatalog instead of ExternalCatalog now.SessionCatalogSuite has similar test case, so no need to create new one.
SparkQA
commented
Apr 9, 2018
Test build #89072 has finished for PR 21001 at commit
|
SparkQA
commented
Apr 9, 2018
Test build #89071 has finished for PR 21001 at commit
|
SparkQA
commented
Apr 10, 2018
Test build #89080 has finished for PR 21001 at commit
|
There was a problem hiding this comment.
We should not remove this logic here, even it's also done in SessionCatalog
ffd0c66 to
c4f359aCompareSparkQA
commented
Apr 10, 2018
Test build #89115 has finished for PR 21001 at commit
|
gatorsmile
commented
Apr 10, 2018
LGTM Thanks! Merged to master. |
SparkQA
commented
Apr 10, 2018
Test build #89124 has finished for PR 21001 at commit
|
What changes were proposed in this pull request?
In the PR #20886, I mistakenly check the table location only when
ignoreIfExistsis false, which was following the original deprecated PR.That was wrong. When
ignoreIfExistsis true and the target table doesn't exist, we should also check the table location. In other word,ignoreIfExistshas nothing to do with table location validation.This is a follow-up PR to fix the mistake.
How was this patch tested?
Add one unit test.