Uh oh!
There was an error while loading. Please reload this page.
[SPARK-23971] Should not leak Spark sessions across test suites - #21058
Closed
ericl wants to merge 1 commit into
Closed
[SPARK-23971] Should not leak Spark sessions across test suites#21058ericl wants to merge 1 commit into
ericl wants to merge 1 commit into
Conversation
ericl
commented
Apr 12, 2018
ContributorAuthor
This is a followup to #20971@gatorsmile |
SparkQA
commented
Apr 12, 2018
Test build #89296 has finished for PR 21058 at commit
|
dongjoon-hyun
commented
Apr 13, 2018
Member
Retest this please. |
SparkQA
commented
Apr 13, 2018
Test build #89307 has finished for PR 21058 at commit
|
gatorsmile
commented
Apr 13, 2018
Member
Thanks! Merged to master. |
gatorsmile pushed a commit
to gatorsmile/spark
that referenced
this pull request
Apr 30, 2018
## What changes were proposed in this pull request? Many suites currently leak Spark sessions (sometimes with stopped SparkContexts) via the thread-local active Spark session and default Spark session. We should attempt to clean these up and detect when this happens to improve the reproducibility of tests. ## How was this patch tested? Existing tests Author: Eric Liang <ekl@databricks.com> Closesapache#21058 from ericl/clear-session.
asfgit pushed a commit
that referenced
this pull request
May 2, 2018
…t suites This PR is to backport the PR #21058 to Apache 2.3. This should be the cause why we saw the test regressions in Apache 2.3 branches: https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.3-test-sbt-hadoop-2.6/317/testReport/org.apache.spark.sql.execution.datasources.parquet/ParquetQuerySuite/SPARK_15678__not_use_cache_on_overwrite/history/https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.3-test-sbt-hadoop-2.7/318/testReport/junit/org.apache.spark.sql/DataFrameSuite/inputFiles/history/ --- ## What changes were proposed in this pull request? Many suites currently leak Spark sessions (sometimes with stopped SparkContexts) via the thread-local active Spark session and default Spark session. We should attempt to clean these up and detect when this happens to improve the reproducibility of tests. ## How was this patch tested? Existing tests Author: Eric Liang <ekl@databricks.com> Closes#21197 from gatorsmile/backportSPARK-23971.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Many suites currently leak Spark sessions (sometimes with stopped SparkContexts) via the thread-local active Spark session and default Spark session. We should attempt to clean these up and detect when this happens to improve the reproducibility of tests.
How was this patch tested?
Existing tests