Skip to content

[SPARK-23992][CORE] ShuffleDependency does not need to be deserialized every time - #21079

Closed
10110346 wants to merge 0 commit into
apache:masterfrom
10110346:notdeserializedep
Closed

[SPARK-23992][CORE] ShuffleDependency does not need to be deserialized every time#21079
10110346 wants to merge 0 commit into
apache:masterfrom
10110346:notdeserializedep

Conversation

@10110346

@1011034610110346 commented Apr 16, 2018

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

In the same stage, 'ShuffleDependency' is not necessary to be deserialized each time.

How was this patch tested?

Existing unit test

@SparkQA

Copy link
Copy Markdown

Test build #89394 has finished for PR 21079 at commit 2239e78.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to clear this cache at the end of a app ?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to clear, this cache can recovery itself

@SparkQA

Copy link
Copy Markdown

Test build #89433 has finished for PR 21079 at commit c647f0a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987

Copy link
Copy Markdown
Contributor

Have you seen any performance improvement with this change?

@HyukjinKwon

Copy link
Copy Markdown
Member

ping @10110346 for ^

@HyukjinKwonHyukjinKwon mentioned this pull request Jul 16, 2018
@10110346

Copy link
Copy Markdown
ContributorAuthor

I'm sorry to be so late reply to you!
I have tested in my production environment, it has a bit of performance improvement. @jiangxb1987@HyukjinKwon

@HyukjinKwon

Copy link
Copy Markdown
Member

Mind if I ask to share the number and post it in the PR description?

@SparkQA

Copy link
Copy Markdown

Test build #94505 has finished for PR 21079 at commit c647f0a.

  • This patch fails Spark unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@10110346@SparkQA@jiangxb1987@HyukjinKwon@Ngone51