Skip to content

[followup][SPARK-10399][SPARK-23879][Core] Free unused off-heap memory in MemoryBlockSuite - #21117

Closed
kiszk wants to merge 1 commit into
apache:masterfrom
kiszk:SPARK-10399-free-offheap
Closed

[followup][SPARK-10399][SPARK-23879][Core] Free unused off-heap memory in MemoryBlockSuite#21117
kiszk wants to merge 1 commit into
apache:masterfrom
kiszk:SPARK-10399-free-offheap

Conversation

@kiszk

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

As @viirya pointed out here, this PR explicitly frees unused off-heap memory in MemoryBlockSuite

How was this patch tested?

Existing UTs

@kiszk

Copy link
Copy Markdown
MemberAuthor

cc @cloud-fan@viirya

@SparkQA

Copy link
Copy Markdown

Test build #89655 has finished for PR 21117 at commit 2c1575d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

Copy link
Copy Markdown
MemberAuthor

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #89668 has finished for PR 21117 at commit 2c1575d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viiryaviirya left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloud-fan

Copy link
Copy Markdown
Contributor

thanks, merging to master!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kiszk@SparkQA@cloud-fan@viirya