Skip to content

[SPARK-24128][SQL] Mention configuration option in implicit CROSS JOIN error - #21201

Closed
henryr wants to merge 2 commits into
apache:masterfrom
henryr:spark-24128
Closed

[SPARK-24128][SQL] Mention configuration option in implicit CROSS JOIN error#21201
henryr wants to merge 2 commits into
apache:masterfrom
henryr:spark-24128

Conversation

@henryr

@henryrhenryr commented May 1, 2018

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Mention spark.sql.crossJoin.enabled in error message when an implicit CROSS JOIN is detected.

How was this patch tested?

CartesianProductSuite and JoinSuite.

gatorsmile
gatorsmile reviewed May 1, 2018
View reviewed changes

@gatorsmilegatorsmile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile

gatorsmile commented May 1, 2018

Copy link
Copy Markdown
Member

retest this please

@felixcheung

felixcheung commented May 1, 2018

Copy link
Copy Markdown
Member

Jenkins, ok to test

@henryr

henryr commented May 1, 2018

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

SparkQA commented May 1, 2018

Copy link
Copy Markdown

Test build #89994 has finished for PR 21201 at commit 215b13f.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented May 1, 2018

Copy link
Copy Markdown

Test build #90014 has finished for PR 21201 at commit b267513.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile

gatorsmile commented May 2, 2018

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented May 2, 2018

Copy link
Copy Markdown

Test build #90019 has finished for PR 21201 at commit b267513.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk

kiszk commented May 2, 2018

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented May 2, 2018

Copy link
Copy Markdown

Test build #90023 has finished for PR 21201 at commit b267513.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

SparkQA commented May 2, 2018

Copy link
Copy Markdown

Test build #90034 has finished for PR 21201 at commit 42d0241.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile

gatorsmile commented May 2, 2018

Copy link
Copy Markdown
Member

Since this PR also impacts the R tests, we need to wait for fixing CRAN issues. Sorry for the delay.

@henryr

henryr commented May 2, 2018

Copy link
Copy Markdown
ContributorAuthor

No problem! It's a small usability fix.

@felixcheung

felixcheung commented May 3, 2018

Copy link
Copy Markdown
Member

Jenkins, retest this please

@SparkQA

SparkQA commented May 3, 2018

Copy link
Copy Markdown

Test build #90101 has finished for PR 21201 at commit 42d0241.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

HyukjinKwon commented May 3, 2018

Copy link
Copy Markdown
Member

retest this please

@SparkQA

SparkQA commented May 3, 2018

Copy link
Copy Markdown

Test build #90109 has finished for PR 21201 at commit 42d0241.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@henryr

henryr commented May 7, 2018

Copy link
Copy Markdown
ContributorAuthor

Any chance to get this merged now the tests are working again? Thanks!

@HyukjinKwon

HyukjinKwon commented May 8, 2018

Copy link
Copy Markdown
Member

Merged to master and branch-2.3.

asfgit pushed a commit that referenced this pull request May 8, 2018
@henryr@HyukjinKwon
[SPARK-24128][SQL] Mention configuration option in implicit CROSS JOI…
4dc6719
…N error
## What changes were proposed in this pull request?
Mention `spark.sql.crossJoin.enabled` in error message when an implicit `CROSS JOIN` is detected.
## How was this patch tested?
`CartesianProductSuite` and `JoinSuite`.
Author: Henry Robinson <henry@apache.org>
Closes#21201 from henryr/spark-24128.
(cherry picked from commit cd12c5c)
Signed-off-by: hyukjinkwon <gurwls223@apache.org>
@asfgitasfgit closed this in cd12c5cMay 8, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatorsmilegatorsmilegatorsmile left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@henryr@gatorsmile@felixcheung@SparkQA@kiszk@HyukjinKwon