Uh oh!
There was an error while loading. Please reload this page.
[SPARK-24129] [K8S] Add option to pass --build-arg's to docker-image-tool.sh - #21202
[SPARK-24129] [K8S] Add option to pass --build-arg's to docker-image-tool.sh#21202devaraj-kavali wants to merge 2 commits into
Conversation
docker-image-tool.sh
felixcheung
commented
May 1, 2018
ok to test |
foxish
commented
May 2, 2018
LGTM pending test run |
foxish
commented
May 2, 2018
jenkins, ok to test |
SparkQA
commented
May 2, 2018
Kubernetes integration test starting |
SparkQA
commented
May 2, 2018
Kubernetes integration test status success |
SparkQA
commented
May 2, 2018
Test build #90033 has finished for PR 21202 at commit
|
devaraj-kavali
commented
May 7, 2018
I don't see any failures related to the change, can you trigger the test again? |
ifilonenko
commented
May 7, 2018
retest this please |
SparkQA
commented
May 7, 2018
Kubernetes integration test starting |
SparkQA
commented
May 7, 2018
Kubernetes integration test status success |
felixcheung
commented
Jun 11, 2018
ok to test |
felixcheung
commented
Jun 11, 2018
@devaraj-kavali could you rebase this? |
SparkQA
commented
Jun 11, 2018
Test build #91647 has finished for PR 21202 at commit
|
SparkQA
commented
Jul 7, 2018
Test build #92701 has finished for PR 21202 at commit
|
srowen
commented
Jul 18, 2018
@devaraj-kavali@skonto just checking this is still something that should be merged, ready to go? |
devaraj-kavali
commented
Jul 18, 2018
@srowen this issue still exists and needs to be merged. |
srowen
commented
Jul 18, 2018
Merged to master |
What changes were proposed in this pull request?
Adding
-b argoption to take--build-argparameters to pass into the docker commandHow was this patch tested?
I verified by passing proxy details which fails without this change and succeeds with the changes.