Skip to content

[SPARK-23852][SQL] Add withSQLConf(...) to test case - #21323

Closed
henryr wants to merge 1 commit into
apache:masterfrom
henryr:spark-23582
Closed

[SPARK-23852][SQL] Add withSQLConf(...) to test case#21323
henryr wants to merge 1 commit into
apache:masterfrom
henryr:spark-23582

Conversation

@henryr

@henryr henryr commented May 14, 2018

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Add a withSQLConf(...) wrapper to force Parquet filter pushdown for a test that relies on it.

How was this patch tested?

Test passes

@vanzin

vanzin commented May 14, 2018

Copy link
Copy Markdown
Contributor

LGTM (pending tests). I'll merge this after #21302 goes in so the script can merge it into 2.3 for me.

@vanzin

vanzin commented May 14, 2018

Copy link
Copy Markdown
Contributor

@henryr looks like the bug is wrong (should be SPARK-23852).

@henryr henryr changed the title [SPARK-23582][SQL] Add withSQLConf(...) to test case [SPARK-23852][SQL] Add withSQLConf(...) to test case May 14, 2018

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thanks.

@SparkQA

SparkQA commented May 14, 2018

Copy link
Copy Markdown

Test build #90602 has finished for PR 21323 at commit fdcacd8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin

vanzin commented May 14, 2018

Copy link
Copy Markdown
Contributor

Merging to master / 2.3.

asfgit pushed a commit that referenced this pull request May 14, 2018
## What changes were proposed in this pull request?

Add a `withSQLConf(...)` wrapper to force Parquet filter pushdown for a test that relies on it.

## How was this patch tested?

Test passes

Author: Henry Robinson <henry@apache.org>

Closes #21323 from henryr/spark-23582.

(cherry picked from commit 061e008)
Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
@asfgit asfgit closed this in 061e008 May 14, 2018
@SparkQA

SparkQA commented May 15, 2018

Copy link
Copy Markdown

Test build #90608 has finished for PR 21323 at commit 56437da.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants