Skip to content

Test branch to see how Scala 2.11.12 performs - #21453

Closed
RussellSpitzer wants to merge 1 commit into
apache:masterfrom
RussellSpitzer:Scala2_11_12_Test
Closed

Test branch to see how Scala 2.11.12 performs#21453
RussellSpitzer wants to merge 1 commit into
apache:masterfrom
RussellSpitzer:Scala2_11_12_Test

Conversation

@RussellSpitzer

Copy link
Copy Markdown
Member

This may be useful when Java 8 is no longer supported since
Scala 2.11.12 supports later versions of Java

What changes were proposed in this pull request?

Change Scala Build Version to 2.11.12.

How was this patch tested?

This PR is made to run 2.11.12 Scala through Jenkins to see whether or not it passes cleanly.

Please review http://spark.apache.org/contributing.html before opening a pull request.

This may be useful when Java 8 is no longer supported since
Scala 2.11.12 supports later versions of Java
@dbtsai

Copy link
Copy Markdown
Member

I'm also looking at this issue. The challenge is that one of the hacks we use to initialize the Spark
before REPL sees any files was removed in Scala 2.11.12.

https://github.com/apache/spark/blob/master/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala#L109

We might need to work with Scala team to upgrade our Scala version.

@dbtsai

Copy link
Copy Markdown
Member

Here is the issue in Scala side. scala/bug#10913

@rxin

rxin commented May 29, 2018

Copy link
Copy Markdown
Contributor

Jenkins, test this please.

@rxin

rxin commented May 29, 2018

Copy link
Copy Markdown
Contributor

Jenkins, add to whitelist.

@HyukjinKwon

Copy link
Copy Markdown
Member

Jenkins, test this please

@HyukjinKwon

Copy link
Copy Markdown
Member

Jenkins, add to whitelist

@SparkQA

Copy link
Copy Markdown

Test build #91322 has finished for PR 21453 at commit 90d3842.

  • This patch fails build dependency tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jerryshao

Copy link
Copy Markdown
Contributor

Scala 2.11.12 cannot be built against with current Spark, due to some method changes in REPL. We have tried internally.

@dbtsai

Copy link
Copy Markdown
Member

I filed an issue in Scala community about the interface changes, and they said those REPL apis are intended to be private. scala/bug#10913

Being said that, they gave us couple ways to walk around it, and I'm testing it now.

@dbtsai

dbtsai commented Jun 5, 2018

Copy link
Copy Markdown
Member

I opened a PR for Scala 2.11.12 with potential Scala API change fix. #21495 Thanks.

@jerryshao

Copy link
Copy Markdown
Contributor

I think we can close this one as a dup of #21495 .

@SparkQA

Copy link
Copy Markdown

Test build #92866 has finished for PR 21453 at commit 90d3842.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowensrowen mentioned this pull request Jul 18, 2018
zifeif2 pushed a commit to zifeif2/spark that referenced this pull request Nov 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@RussellSpitzer@dbtsai@rxin@HyukjinKwon@SparkQA@jerryshao