Skip to content

[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite - #21536

Closed
jiangxb1987 wants to merge 1 commit into
apache:masterfrom
jiangxb1987:sorterSuite
Closed

[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite#21536
jiangxb1987 wants to merge 1 commit into
apache:masterfrom
jiangxb1987:sorterSuite

Conversation

@jiangxb1987

@jiangxb1987jiangxb1987 commented Jun 12, 2018

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

We don't require specific ordering of the input data, the sort action is not necessary and misleading.

How was this patch tested?

Existing test suite.

@SparkQA

SparkQA commented Jun 12, 2018

Copy link
Copy Markdown

Test build #91691 has finished for PR 21536 at commit 2ea2181.

  • This patch fails Java style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon

HyukjinKwon commented Jun 12, 2018

Copy link
Copy Markdown
Member

Hm .. ? retest this please

@SparkQA

SparkQA commented Jun 12, 2018

Copy link
Copy Markdown

Test build #91695 has finished for PR 21536 at commit 2ea2181.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987

jiangxb1987 commented Jun 12, 2018

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

SparkQA commented Jun 12, 2018

Copy link
Copy Markdown

Test build #91721 has finished for PR 21536 at commit 2ea2181.

  • This patch fails Java style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987

jiangxb1987 commented Jun 13, 2018

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

SparkQA commented Jun 13, 2018

Copy link
Copy Markdown

Test build #91746 has finished for PR 21536 at commit 2ea2181.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987

jiangxb1987 commented Jun 13, 2018

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

SparkQA commented Jun 13, 2018

Copy link
Copy Markdown

Test build #91753 has finished for PR 21536 at commit 2ea2181.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@jiangxb1987

jiangxb1987 commented Jun 14, 2018

Copy link
Copy Markdown
ContributorAuthor

@HyukjinKwon can we merge this?

@HyukjinKwon

HyukjinKwon commented Jun 14, 2018

Copy link
Copy Markdown
Member

Sure.

HyukjinKwon
HyukjinKwon approved these changes Jun 14, 2018
View reviewed changes

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyukjinKwon

HyukjinKwon commented Jun 14, 2018

Copy link
Copy Markdown
Member

Merged to master and branch-2.3.

asfgit pushed a commit that referenced this pull request Jun 14, 2018
@jiangxb1987@HyukjinKwon
[MINOR][CORE][TEST] Remove unnecessary sort in UnsafeInMemorySorterSuite
a2f65eb
## What changes were proposed in this pull request?
We don't require specific ordering of the input data, the sort action is not necessary and misleading.
## How was this patch tested?
Existing test suite.
Author: Xingbo Jiang <xingbo.jiang@databricks.com>
Closes#21536 from jiangxb1987/sorterSuite.
(cherry picked from commit 534065e)
Signed-off-by: hyukjinkwon <gurwls223@apache.org>
@jiangxb1987

jiangxb1987 commented Jun 14, 2018

Copy link
Copy Markdown
ContributorAuthor

Thanks! @HyukjinKwon

@jiangxb1987
jiangxb1987 deleted the sorterSuite branch June 14, 2018 06:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyukjinKwonHyukjinKwonHyukjinKwon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiangxb1987@SparkQA@HyukjinKwon