Uh oh!
There was an error while loading. Please reload this page.
[SPARK-24715][Build] Override jline version as 2.14.3 in SBT - #21692
[SPARK-24715][Build] Override jline version as 2.14.3 in SBT#21692viirya wants to merge 1 commit into
Conversation
viirya
commented
Jul 2, 2018
HyukjinKwon
commented
Jul 2, 2018
Nice! Mind if I ask to show the diff between |
viirya
commented
Jul 2, 2018
Hmm, it seems hard to compare the diff between |
If we don't override this, which jline version does |
viirya
commented
Jul 2, 2018
I've seen |
SparkQA
commented
Jul 2, 2018
Test build #92521 has finished for PR 21692 at commit
|
maropu
commented
Jul 2, 2018
Thanks, I feel it'd be better to put concrete version numbers in the description. |
viirya
commented
Jul 2, 2018
@maropu Thanks. Version number is in the description now. |
HyukjinKwon
commented
Jul 2, 2018
Merged to master. |
dbtsai
commented
Jul 2, 2018
@viirya thanks for this PR. I thought SBT always uses pom for dependencies, and I wonder why there is a discrepancy so we need to manually override it? |
srowen
commented
Jul 2, 2018
I haven't looked into this particular issue thoroughly, but, I'm aware that SBT and Maven don't actually resolve dependencies in quite the same way. I think the resolve conflicts with different rules -- most recent wins vs 'nearest' wins. Could be it. |
dongjoon-hyun
commented
Jul 3, 2018
Thank you all! |
viirya
commented
Jul 3, 2018
Thanks @srowen for explanation. As I can tell, |
What changes were proposed in this pull request?
During SPARK-24418 (Upgrade Scala to 2.11.12 and 2.12.6), we upgrade
jlineversion together. So,mvnworks correctly. However,sbtbrings old jline library and is hittingNoSuchMethodErrorinmasterbranch, see #21495 (comment). This overrides jline version in SBT to make sbt build work.How was this patch tested?
Manually test.