Uh oh!
There was an error while loading. Please reload this page.
[MINOR][CORE] Add test cases for RDD.cartesian - #21765
Closed
NiharS wants to merge 2 commits into
Closed
Conversation
SparkQA
commented
Jul 15, 2018
Test build #4213 has finished for PR 21765 at commit
|
SparkQA
commented
Jul 16, 2018
Test build #4215 has finished for PR 21765 at commit
|
SparkQA
commented
Jul 16, 2018
Test build #4216 has finished for PR 21765 at commit
|
The scala code for RDD.cartesian does not have any tests for correctness. This adds a couple basic tests to verify cartesian yields correct values. Passes the added test cases, and passes the scala style tests. Author: Nihar Sheth <niharrsheth@gmail.com>
NiharS
commented
Jul 17, 2018
ContributorAuthor
Rebased onto SPARK-24813 so hopefully tests will work now |
srowen
commented
Jul 17, 2018
Member
Yup it will always apply your PR to master anyway, so would have picked it up in this test run. |
SparkQA
commented
Jul 17, 2018
Test build #4217 has finished for PR 21765 at commit
|
SparkQA
commented
Jul 18, 2018
Test build #4218 has finished for PR 21765 at commit
|
srowen
commented
Jul 18, 2018
Member
Merged to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
While looking through the codebase, it appeared that the scala code for RDD.cartesian does not have any tests for correctness. This adds a couple basic tests to verify cartesian yields correct values. While the implementation for RDD.cartesian is pretty simple, it always helps to have a few tests!
How was this patch tested?
The new test cases pass, and the scala style tests from running dev/run-tests all pass.
Please review http://spark.apache.org/contributing.html before opening a pull request.