Skip to content

[SPARK-24825][K8S][TEST] Kubernetes integration tests build the whole reactor - #21800

Closed
mccheah wants to merge 2 commits into
apache:masterfrom
palantir:k8s-integration-tests-maven-fix
Closed

[SPARK-24825][K8S][TEST] Kubernetes integration tests build the whole reactor#21800
mccheah wants to merge 2 commits into
apache:masterfrom
palantir:k8s-integration-tests-maven-fix

Conversation

@mccheah

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Make the integration test script build all modules.

In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.

How was this patch tested?

The build system will test this.

… reactor.
In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.
@mccheah

Copy link
Copy Markdown
ContributorAuthor

test this please

@shaneknapp

Copy link
Copy Markdown
Contributor

quick comment (from @jey ):

add set -x to the top (after the shebang) of resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh

this way we can see what's happening in that script during the build.

@SparkQA

Copy link
Copy Markdown

@jey

jey commented Jul 18, 2018

Copy link
Copy Markdown
Contributor

To add to @shaneknapp's comment, please add set -o errexit to your shell script so that it will exit with a nonzero code if any of its commands fail. The absence of this causes the tests to claim to pass even when there's an error, since the dev-run-integration-tests.sh still returns a 0 exit code.

fi

../../../build/mvn integration-test ${properties[@]}
$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pkubernetes -Phadoop-2.7 ${properties[@]}

@skontoskontoJul 18, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. We need to skip top level unit tests here I guess tags do that. I was wondering if there is another way.

@SparkQA

Copy link
Copy Markdown

@mccheah

Copy link
Copy Markdown
ContributorAuthor

Addressed comments

@SparkQA

Copy link
Copy Markdown

@SparkQA

Copy link
Copy Markdown

@shaneknapp

Copy link
Copy Markdown
Contributor

LGTM

@SparkQA

Copy link
Copy Markdown

Test build #93209 has finished for PR 21800 at commit 6a89c65.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA

Copy link
Copy Markdown

Test build #93210 has finished for PR 21800 at commit d6f41e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@robert3005
robert3005 deleted the k8s-integration-tests-maven-fix branch August 11, 2018 05:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@mccheah@shaneknapp@SparkQA@jey@skonto