Uh oh!
There was an error while loading. Please reload this page.
[SPARK-24825][K8S][TEST] Kubernetes integration tests build the whole reactor - #21800
[SPARK-24825][K8S][TEST] Kubernetes integration tests build the whole reactor#21800mccheah wants to merge 2 commits into
Conversation
… reactor. In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.
mccheah
commented
Jul 18, 2018
test this please |
shaneknapp
commented
Jul 18, 2018
quick comment (from @jey ): add this way we can see what's happening in that script during the build. |
SparkQA
commented
Jul 18, 2018
Kubernetes integration test starting |
To add to @shaneknapp's comment, please add |
| fi | ||
| ../../../build/mvn integration-test ${properties[@]} | ||
| $TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl resource-managers/kubernetes/integration-tests -am -Pkubernetes -Phadoop-2.7 ${properties[@]} |
There was a problem hiding this comment.
+1. We need to skip top level unit tests here I guess tags do that. I was wondering if there is another way.
SparkQA
commented
Jul 18, 2018
Kubernetes integration test status success |
mccheah
commented
Jul 18, 2018
Addressed comments |
SparkQA
commented
Jul 18, 2018
Kubernetes integration test starting |
SparkQA
commented
Jul 18, 2018
Kubernetes integration test status success |
shaneknapp
commented
Jul 18, 2018
LGTM |
SparkQA
commented
Jul 18, 2018
Test build #93209 has finished for PR 21800 at commit
|
SparkQA
commented
Jul 18, 2018
Test build #93210 has finished for PR 21800 at commit
|
What changes were proposed in this pull request?
Make the integration test script build all modules.
In order to not run all the non-Kubernetes integration tests in the build, support specifying tags and tag all integration tests specifically with "k8s". Supply the k8s tag in the dev/dev-run-integration-tests.sh script.
How was this patch tested?
The build system will test this.