Skip to content

[minor] remove dead code in ExpressionEvalHelper - #21958

Closed
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:minor
Closed

[minor] remove dead code in ExpressionEvalHelper#21958
cloud-fan wants to merge 1 commit into
apache:masterfrom
cloud-fan:minor

Conversation

@cloud-fan

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

This addresses https://github.com/apache/spark/pull/21236/files#r207078480

both #21236 and #21838 add a InternalRow result check to ExpressionEvalHelper and becomes duplicated.

How was this patch tested?

N/A

@holdensmagicalunicorn

Copy link
Copy Markdown

@cloud-fan, thanks! I am a bot who has found some folks who might be able to help with the review:@ueshin, @rxin and @JoshRosen

@cloud-fan

Copy link
Copy Markdown
ContributorAuthor

cc @srowen@gatorsmile

@gatorsmile

Copy link
Copy Markdown
Member

LGTM

@SparkQA

Copy link
Copy Markdown

Test build #93949 has finished for PR 21958 at commit 19dd614.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin

Copy link
Copy Markdown
Member

Jenkins, retest this please.

@ueshin

Copy link
Copy Markdown
Member

LGTM.

@SparkQA

Copy link
Copy Markdown

Test build #93976 has finished for PR 21958 at commit 19dd614.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan

Copy link
Copy Markdown
ContributorAuthor

retest this please

@SparkQA

Copy link
Copy Markdown

Test build #93987 has finished for PR 21958 at commit 19dd614.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen

Copy link
Copy Markdown
Member

Thanks, merged to master

@asfgitasfgit closed this in f04cd67Aug 2, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@cloud-fan@holdensmagicalunicorn@gatorsmile@SparkQA@ueshin@srowen