Uh oh!
There was an error while loading. Please reload this page.
[SPARK-24987][SS] - Fix Kafka consumer leak when no new offsets for TopicPartition - #21983
Closed
YuvalItzchakov wants to merge 2 commits into
Closed
[SPARK-24987][SS] - Fix Kafka consumer leak when no new offsets for TopicPartition#21983YuvalItzchakov wants to merge 2 commits into
YuvalItzchakov wants to merge 2 commits into
Conversation
koeninger
commented
Aug 3, 2018
Contributor
Jenkins, ok to test |
SparkQA
commented
Aug 3, 2018
Test build #94133 has finished for PR 21983 at commit
|
YuvalItzchakov
commented
Aug 4, 2018
Author
Should I create a separate PR for the master branch? |
felixcheung
commented
Aug 4, 2018
Member
@YuvalItzchakov you should open the PR against master - it can be picked to release branch (eg. 2.3) when merged. |
YuvalItzchakov
commented
Aug 4, 2018
Author
@felixcheung Thanks, will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This small fix adds a
consumer.release()call toKafkaSourceRDDin the case where we've retrieved offsets from Kafka, but thefromOffsetis equal to thelastOffset, meaning there is no new data to read for a particular topic partition. Up until now, we'd just return an empty iterator without closing the consumer which would cause a FD leak.If accepted, this pull request should be merged into master as well.
How was this patch tested?
Haven't ran any specific tests, would love help on how to test methods running inside
RDD.compute.