Uh oh!
There was an error while loading. Please reload this page.
[SPARK-24948][SHS][BACKPORT-2.2] Delegate check access permissions to the file system - #22022
Closed
mgaido91 wants to merge 4 commits into
Closed
[SPARK-24948][SHS][BACKPORT-2.2] Delegate check access permissions to the file system#22022mgaido91 wants to merge 4 commits into
mgaido91 wants to merge 4 commits into
Conversation
In `SparkHadoopUtil. checkAccessPermission`, we consider only basic permissions in order to check wether a user can access a file or not. This is not a complete check, as it ignores ACLs and other policies a file system may apply in its internal. So this can result in returning wrongly that a user cannot access a file (despite he actually can). The PR proposes to delegate to the filesystem the check whether a file is accessible or not, in order to return the right result. A caching layer is added for performance reasons. modified UTs Author: Marco Gaido <marcogaido91@gmail.com> Closesapache#21895 from mgaido91/SPARK-24948.
SparkQA
commented
Aug 7, 2018
Test build #94360 has finished for PR 22022 at commit
|
mgaido91
commented
Aug 7, 2018
ContributorAuthor
SparkQA
commented
Aug 7, 2018
Test build #94361 has finished for PR 22022 at commit
|
HyukjinKwon
commented
Aug 7, 2018
Member
retest this please |
SparkQA
commented
Aug 7, 2018
Test build #94369 has finished for PR 22022 at commit
|
SparkQA
commented
Aug 7, 2018
Test build #94374 has finished for PR 22022 at commit
|
jerryshao
approved these changes
Aug 8, 2018
jerryshao
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Merging to branch 2.2
Contributor
Sorry, let me test again to see everything is ok. Will merge it when test is passed. |
jerryshao
commented
Aug 8, 2018
Contributor
Jenkins, retest this please. |
SparkQA
commented
Aug 8, 2018
Test build #94401 has finished for PR 22022 at commit
|
asfgit pushed a commit
that referenced
this pull request
Aug 8, 2018
… the file system ## What changes were proposed in this pull request? In `SparkHadoopUtil. checkAccessPermission`, we consider only basic permissions in order to check whether a user can access a file or not. This is not a complete check, as it ignores ACLs and other policies a file system may apply in its internal. So this can result in returning wrongly that a user cannot access a file (despite he actually can). The PR proposes to delegate to the filesystem the check whether a file is accessible or not, in order to return the right result. A caching layer is added for performance reasons. ## How was this patch tested? added UT Author: Marco Gaido <marcogaido91@gmail.com> Closes#22022 from mgaido91/SPARK-24948_2.2.
jerryshao
commented
Aug 8, 2018
Contributor
Merged to branch 2.2, please close this PR @mgaido91 |
mgaido91
commented
Aug 8, 2018
ContributorAuthor
Thanks @jerryshao , closing. |
Willymontaz pushed a commit
to criteo-forks/spark
that referenced
this pull request
Sep 26, 2019
… the file system ## What changes were proposed in this pull request? In `SparkHadoopUtil. checkAccessPermission`, we consider only basic permissions in order to check whether a user can access a file or not. This is not a complete check, as it ignores ACLs and other policies a file system may apply in its internal. So this can result in returning wrongly that a user cannot access a file (despite he actually can). The PR proposes to delegate to the filesystem the check whether a file is accessible or not, in order to return the right result. A caching layer is added for performance reasons. ## How was this patch tested? added UT Author: Marco Gaido <marcogaido91@gmail.com> Closesapache#22022 from mgaido91/SPARK-24948_2.2.
Willymontaz pushed a commit
to criteo-forks/spark
that referenced
this pull request
Sep 27, 2019
… the file system ## What changes were proposed in this pull request? In `SparkHadoopUtil. checkAccessPermission`, we consider only basic permissions in order to check whether a user can access a file or not. This is not a complete check, as it ignores ACLs and other policies a file system may apply in its internal. So this can result in returning wrongly that a user cannot access a file (despite he actually can). The PR proposes to delegate to the filesystem the check whether a file is accessible or not, in order to return the right result. A caching layer is added for performance reasons. ## How was this patch tested? added UT Author: Marco Gaido <marcogaido91@gmail.com> Closesapache#22022 from mgaido91/SPARK-24948_2.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
SparkHadoopUtil. checkAccessPermission, we consider only basic permissions in order to check whether a user can access a file or not. This is not a complete check, as it ignores ACLs and other policies a file system may apply in its internal. So this can result in returning wrongly that a user cannot access a file (despite he actually can).The PR proposes to delegate to the filesystem the check whether a file is accessible or not, in order to return the right result. A caching layer is added for performance reasons.
How was this patch tested?
added UT