Skip to content

[SPARK-25144][SQL][TEST] Free aggregate map when task ends - #22155

Closed
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-25144-2
Closed

[SPARK-25144][SQL][TEST] Free aggregate map when task ends#22155
dongjoon-hyun wants to merge 1 commit into
apache:masterfrom
dongjoon-hyun:SPARK-25144-2

Conversation

@dongjoon-hyun

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

SPARK-25144 reports memory leaks on Apache Spark 2.0.2 ~ 2.3.2-RC5. The bug is already fixed via #21738 as a part of SPARK-21743. This PR only adds a test case to prevent any future regression.

scala>caseclassFoo(bar: Option[String])
scala>valds=List(Foo(Some("bar"))).toDS
scala>valresult= ds.flatMap(_.bar).distinct
scala> result.rdd.isEmpty
18/08/1923:01:54WARNExecutor:Managed memory leak detected; size =8650752 bytes, TID=125
res0:Boolean=false

How was this patch tested?

Pass the Jenkins with a new added test case.

@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

cc @HyukjinKwon

@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

Thank you for review and approval, @HyukjinKwon .

@SparkQA

Copy link
Copy Markdown

Test build #94962 has finished for PR 22155 at commit 27497f5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class Foo(bar: Option[String])

@HyukjinKwon

Copy link
Copy Markdown
Member

Merged to master.

@dongjoon-hyun

Copy link
Copy Markdown
MemberAuthor

Thank you!

@dongjoon-hyun
dongjoon-hyun deleted the SPARK-25144-2 branch August 21, 2018 03:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dongjoon-hyun@SparkQA@HyukjinKwon