Uh oh!
There was an error while loading. Please reload this page.
Revert [SPARK-24882][SQL] improve data source v2 API from branch 2.4 - #22388
Revert [SPARK-24882][SQL] improve data source v2 API from branch 2.4#22388cloud-fan wants to merge 6 commits into
Conversation
SparkQA
commented
Sep 11, 2018
Test build #95912 has finished for PR 22388 at commit
|
dongjoon-hyun
commented
Sep 11, 2018
This seems to be the complete revert of SPARK-24882 (#22009 and the followup #22245). Am I right? |
cloud-fan
commented
Sep 11, 2018
yes |
SparkQA
commented
Sep 12, 2018
Test build #95967 has finished for PR 22388 at commit
|
SparkQA
commented
Sep 12, 2018
Test build #95968 has finished for PR 22388 at commit
|
kiszk
commented
Sep 12, 2018
Incorrect import still may exist there. |
jose-torres
commented
Sep 12, 2018
MicroBatchExecution.scala and ContinuousExecution.scala look right after the revert, although it would be helpful to understand what the diff is between this and a straight |
SparkQA
commented
Sep 12, 2018
Test build #95986 has finished for PR 22388 at commit
|
## What changes were proposed in this pull request? As discussed in the dev list, we don't want to include #22009 in Spark 2.4, as it needs data source v2 users to change the implementation intensitively, while they need to change again in next release. ## How was this patch tested? existing tests Author: Wenchen Fan <wenchen@databricks.com> Closes#22388 from cloud-fan/revert.
gatorsmile
commented
Sep 12, 2018
Unable to merge to master. @cloud-fan Could you submit another PR to the master branch? |
dongjoon-hyun
commented
Sep 12, 2018
Ur, @gatorsmile . Why do we need to revert this from |
cloud-fan
commented
Sep 13, 2018
As we discussed in the dev list, we only want to revert it from 2.4. I'm closing it now. |
rdblue
commented
Sep 17, 2018
Thanks for doing this, @cloud-fan! Sorry I'm late to reply, I was at Strata all last week. |
What changes were proposed in this pull request?
As discussed in the dev list, we don't want to include #22009 in Spark 2.4, as it needs data source v2 users to change the implementation intensitively, while they need to change again in next release.
How was this patch tested?
existing tests