Skip to content

[SPARK-25559] [FOLLOW-UP] Add comments for partial pushdown of conjuncts in Parquet - #22679

Closed
gatorsmile wants to merge 1 commit into
apache:masterfrom
gatorsmile:followupSPARK-25559
Closed

[SPARK-25559] [FOLLOW-UP] Add comments for partial pushdown of conjuncts in Parquet#22679
gatorsmile wants to merge 1 commit into
apache:masterfrom
gatorsmile:followupSPARK-25559

Conversation

@gatorsmile

Copy link
Copy Markdown
Member

What changes were proposed in this pull request?

This is a follow up of #22574. Renamed the parameter and added comments.

How was this patch tested?

N/A

@gatorsmile

Copy link
Copy Markdown
MemberAuthor

cc @dbtsai@cloud-fan

@dbtsai

Copy link
Copy Markdown
Member

LGTM. Wait for the PR build. Thanks.

@dongjoon-hyundongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA

Copy link
Copy Markdown

Test build #97167 has finished for PR 22679 at commit 3840d44.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai

Copy link
Copy Markdown
Member

Thanks. Merged into master.

@asfgitasfgit closed this in faf73dcOct 9, 2018

@HyukjinKwonHyukjinKwon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…ts in Parquet
## What changes were proposed in this pull request?
This is a follow up of apache#22574. Renamed the parameter and added comments.
## How was this patch tested?
N/A
Closesapache#22679 from gatorsmile/followupSPARK-25559.
Authored-by: gatorsmile <gatorsmile@gmail.com>
Signed-off-by: DB Tsai <d_tsai@apple.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@gatorsmile@dbtsai@SparkQA@HyukjinKwon@dongjoon-hyun