Uh oh!
There was an error while loading. Please reload this page.
[SPARK-25700][SQL][BRANCH-2.4] Partially revert append mode support in Data Source V2 - #22697
Closed
HyukjinKwon wants to merge 1 commit into
Closed
[SPARK-25700][SQL][BRANCH-2.4] Partially revert append mode support in Data Source V2#22697HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
HyukjinKwonforce-pushed
the
append-revert-2.4
branch
from
October 11, 2018 12:55
540d4b9 to
b836625CompareSparkQA
commented
Oct 11, 2018
Test build #97262 has finished for PR 22697 at commit
|
SparkQA
commented
Oct 11, 2018
Test build #97260 has finished for PR 22697 at commit
|
SparkQA
commented
Oct 11, 2018
Test build #97261 has finished for PR 22697 at commit
|
HyukjinKwon
commented
Oct 11, 2018
MemberAuthor
retest this please |
dongjoon-hyun
commented
Oct 11, 2018
Member
The following failure looks persistent and relevant. |
MemberAuthor
That was another commit before rebasing. |
SparkQA
commented
Oct 11, 2018
Test build #97271 has finished for PR 22697 at commit
|
dongjoon-hyun
commented
Oct 11, 2018
Member
Retest this please. |
SparkQA
commented
Oct 12, 2018
Test build #97281 has finished for PR 22697 at commit
|
HyukjinKwon
commented
Oct 13, 2018
MemberAuthor
cc @cloud-fan |
cloud-fan
commented
Oct 15, 2018
Contributor
thanks, merging to 2.4! |
asfgit pushed a commit
that referenced
this pull request
Oct 15, 2018
…n Data Source V2 ## What changes were proposed in this pull request? This PR proposes to partially revert 5fef6e3 so that it does make a readsupport and read schema when it writes in branch 2-4 since it's too breaking change. 5fef6e3 happened to create a readsupport in write path, which ended up with reading schema from readsupport at write path. For instance, this breaks `spark.range(1).format("source").write.save("non-existent-path")` case since there's no way to read the schema from "non-existent-path". See also #22009 (comment) See also #22688 See also http://apache-spark-developers-list.1001551.n3.nabble.com/Possible-bug-in-DatasourceV2-td25343.html ## How was this patch tested? Unit test and manual tests. Closes#22697 from HyukjinKwon/append-revert-2.4. Authored-by: hyukjinkwon <gurwls223@apache.org> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
bavardage pushed a commit
to palantir/spark
that referenced
this pull request
Oct 25, 2018
…urce V2 write path ## What changes were proposed in this pull request? This PR proposes to avoid to make a readsupport and read schema when it writes in other save modes. apache@5fef6e3 happened to create a readsupport in write path, which ended up with reading schema from readsupport at write path. This breaks `spark.range(1).format("source").write.save("non-existent-path")` case since there's no way to read the schema from "non-existent-path". See also apache#22009 (comment) See also apache#22697 See also http://apache-spark-developers-list.1001551.n3.nabble.com/Possible-bug-in-DatasourceV2-td25343.html ## How was this patch tested? Unit test and manual tests. Closesapache#22688 from HyukjinKwon/append-revert-2. Authored-by: hyukjinkwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
jackylee-ch pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…urce V2 write path ## What changes were proposed in this pull request? This PR proposes to avoid to make a readsupport and read schema when it writes in other save modes. apache@5fef6e3 happened to create a readsupport in write path, which ended up with reading schema from readsupport at write path. This breaks `spark.range(1).format("source").write.save("non-existent-path")` case since there's no way to read the schema from "non-existent-path". See also apache#22009 (comment) See also apache#22697 See also http://apache-spark-developers-list.1001551.n3.nabble.com/Possible-bug-in-DatasourceV2-td25343.html ## How was this patch tested? Unit test and manual tests. Closesapache#22688 from HyukjinKwon/append-revert-2. Authored-by: hyukjinkwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to partially revert 5fef6e3 so that it does make a readsupport and read schema when it writes in branch 2-4 since it's too breaking change.
5fef6e3 happened to create a readsupport in write path, which ended up with reading schema from readsupport at write path.
For instance, this breaks
spark.range(1).format("source").write.save("non-existent-path")case since there's no way to read the schema from "non-existent-path".See also #22009 (comment)
See also #22688
See also http://apache-spark-developers-list.1001551.n3.nabble.com/Possible-bug-in-DatasourceV2-td25343.html
How was this patch tested?
Unit test and manual tests.