Uh oh!
There was an error while loading. Please reload this page.
[SPARK-25785][SQL] Add prettyNames for from_json, to_json, from_csv, and schema_of_json - #22773
[SPARK-25785][SQL] Add prettyNames for from_json, to_json, from_csv, and schema_of_json#22773HyukjinKwon wants to merge 1 commit into
Conversation
SparkQA
commented
Oct 19, 2018
Test build #97591 has finished for PR 22773 at commit
|
HyukjinKwon
commented
Oct 19, 2018
retest this please |
SparkQA
commented
Oct 19, 2018
Test build #97599 has finished for PR 22773 at commit
|
viirya
commented
Oct 19, 2018
retest this please. |
viirya
commented
Oct 19, 2018
LGTM |
SparkQA
commented
Oct 19, 2018
Test build #97604 has finished for PR 22773 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
LG, but could you make this as a follow-up for the existing issues or create a new one?
HyukjinKwon
commented
Oct 20, 2018
Other JIRAs have different fixed versions. Let me create a new JIRA then. |
HyukjinKwon
commented
Oct 20, 2018
Merged to master. |
HyukjinKwon
commented
Oct 20, 2018
Thank you @viirya and @dongjoon-hyun. |
This is an external change. This needs a migration guide update. Column names in schema are changed by this PR |
HyukjinKwon
commented
Oct 25, 2018
That's the exact issue I raised before and we ended up with not keeping the compatibility in column names. @cloud-fan and @hvanhovell. |
HyukjinKwon
commented
Oct 25, 2018
BTW, it's closer to bug rather then improvement tho. |
cloud-fan
commented
Oct 25, 2018
I think the new names are better and expected, though it's safer to mention it in the migration guide in case some users care about it. |
My impression so far was that we note things at migration notes when they are improvements (not bugs), and non-trivial and related to backward compatibility. Shall we clarify what to document at migration guide? Otherwise we should document everything related with, let's say, all external changes, deprecation removal, trivial changes, and many other changes related with column names. |
gatorsmile
commented
Oct 25, 2018
All the things that could break the existing user applications should be documented in the migration guide. This will simplify the system upgrade of our end users. |
Sure, so for clarification, we will document everything that could break external users applications in any way, right? |
gatorsmile
commented
Oct 25, 2018
Yes. The goal of migration guide is for helping end users upgrade their Spark. |
HyukjinKwon
commented
Oct 25, 2018
Yup, will encourage to update the migration guide in that way. |
…and schema_of_json ## What changes were proposed in this pull request? This PR adds `prettyNames` for `from_json`, `to_json`, `from_csv`, and `schema_of_json` so that appropriate names are used. ## How was this patch tested? Unit tests Closesapache#22773 from HyukjinKwon/minor-prettyNames. Authored-by: hyukjinkwon <gurwls223@apache.org> Signed-off-by: hyukjinkwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR adds
prettyNamesforfrom_json,to_json,from_csv, andschema_of_jsonso that appropriate names are used.How was this patch tested?
Unit tests