Uh oh!
There was an error while loading. Please reload this page.
[SPARK-25772][SQL][FOLLOWUP] remove GetArrayFromMap - #22825
Closed
cloud-fan wants to merge 1 commit into
Closed
Conversation
cloud-fan
commented
Oct 25, 2018
ContributorAuthor
SparkQA
commented
Oct 25, 2018
Test build #98021 has finished for PR 22825 at commit
|
viirya
commented
Oct 26, 2018
Member
Nice catch! LGTM |
cloud-fan
commented
Oct 26, 2018
ContributorAuthor
thanks, merging to master! |
jackylee-ch pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? In apache#22745 we introduced the `GetArrayFromMap` expression. Later on I realized this is duplicated as we already have `MapKeys` and `MapValues`. This PR removes `GetArrayFromMap` ## How was this patch tested? existing tests Closesapache#22825 from cloud-fan/minor. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #22745 we introduced the
GetArrayFromMapexpression. Later on I realized this is duplicated as we already haveMapKeysandMapValues.This PR removes
GetArrayFromMapHow was this patch tested?
existing tests