Uh oh!
There was an error while loading. Please reload this page.
[SPARK-25758][ML] Deprecate computeCost in BisectingKMeans - #22869
Closed
mgaido91 wants to merge 1 commit into
Closed
[SPARK-25758][ML] Deprecate computeCost in BisectingKMeans#22869mgaido91 wants to merge 1 commit into
mgaido91 wants to merge 1 commit into
Conversation
mgaido91
commented
Oct 28, 2018
ContributorAuthor
Since #22756 was reverted because it was decided not to deprecate this in 2.4, but only in 3.0, this PR deprecates it for 3.0. |
SparkQA
commented
Oct 28, 2018
Test build #98168 has finished for PR 22869 at commit
|
mgaido91
commented
Nov 5, 2018
ContributorAuthor
any comments on this? |
cloud-fan
commented
Nov 5, 2018
Contributor
cc @dbtsai |
dbtsai
commented
Nov 5, 2018
Member
LGTM too. Merged into master. Thanks. |
jackylee-ch pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? The PR proposes to deprecate the `computeCost` method on `BisectingKMeans` in favor of the adoption of `ClusteringEvaluator` in order to evaluate the clustering. ## How was this patch tested? NA Closesapache#22869 from mgaido91/SPARK-25758_3.0. Authored-by: Marco Gaido <marcogaido91@gmail.com> Signed-off-by: DB Tsai <d_tsai@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The PR proposes to deprecate the
computeCostmethod onBisectingKMeansin favor of the adoption ofClusteringEvaluatorin order to evaluate the clustering.How was this patch tested?
NA